Skip to content

test: add filter integration tests #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shahnami merged 16 commits into from
Jan 24, 2025
Merged

test: add filter integration tests #29

shahnami merged 16 commits into from
Jan 24, 2025

Conversation

@shahnami
Copy link
Member

@shahnami shahnami commented Jan 23, 2025 •
edited
Loading

Summary

  • Added integration tests for filter_block and handle_match for EVM and Stellar;
  • Added TriggerExecutionServiceTrait for easy mocking;
  • Created mock for TriggerExecutionService;
  • Removed logic related to populating matched_on_args when there is no expression defined;
  • Added "0x" prefix for short function signatures;
  • Moved bootstrap functions from main.rs into bootstrap module;
  • Added tests for filter functionality in bootstrap.

https://linear.app/openzeppelin-development/issue/PLAT-6048/add-integration-tests

Testing Process

Checklist

  • Add a reference to related issues in the PR description.
  • Add unit tests if applicable.

@shahnami shahnami requested a review from NicoMolinaOZ January 23, 2025 13:46
@shahnami shahnami added A-tests Test setup and integration P-high Critical tasks or blockers S-in-progress Actively being worked on T-task General tasks or chores (e.g., refactoring, cleanup) labels Jan 24, 2025
NicoMolinaOZ
NicoMolinaOZ reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@NicoMolinaOZ NicoMolinaOZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice job!

@shahnami shahnami merged commit 1bde5f6 into main Jan 24, 2025
14 checks passed
@shahnami shahnami deleted the plat-6048-add-integration-tests branch January 24, 2025 17:40
@shahnami shahnami added S-closed Completed and closed issues and removed S-in-progress Actively being worked on labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicoMolinaOZ NicoMolinaOZ NicoMolinaOZ approved these changes

@CoveMB CoveMB Awaiting requested review from CoveMB

@collins-w collins-w Awaiting requested review from collins-w

@dylankilkenny dylankilkenny Awaiting requested review from dylankilkenny

@emnul emnul Awaiting requested review from emnul

@MCarlomagno MCarlomagno Awaiting requested review from MCarlomagno

@tirumerla tirumerla Awaiting requested review from tirumerla

@zeljkoX zeljkoX Awaiting requested review from zeljkoX

Assignees

No one assigned

Labels

A-tests Test setup and integration P-high Critical tasks or blockers S-closed Completed and closed issues T-task General tasks or chores (e.g., refactoring, cleanup)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shahnami @NicoMolinaOZ