Skip to content

ci: CI and CodeCov Integration #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tirumerla merged 69 commits into from
Jan 24, 2025
Merged

ci: CI and CodeCov Integration #31

tirumerla merged 69 commits into from
Jan 24, 2025

Conversation

@collins-w
Copy link
Contributor

@collins-w collins-w commented Jan 24, 2025

Summary

  • Integrates CI
  • Integrates CodeCov

Testing Process

Checklist

  • Add a reference to related issues in the PR description.
  • Add unit tests if applicable.

shahnami and others added 30 commits January 17, 2025 20:29
@shahnami
chore: gracefully handle unwraps
c044fab
@shahnami
chore: replace dyn error in storage interface for blockwatchererror
d3fe561
@KitHat @shahnami
chore: remove dyn from block processor
ca92aa0
@shahnami
chore: add box back
17fa996
@shahnami
chore: add box back to monitormatch
0ad17be
@shahnami
chore: re-add async trait
d89a42c
@KitHat
fixed check
91e130a
@shahnami
chore: add comments as to why we are using Box
fe0cea9
@shahnami
chore: lint and comments
06df623
@shahnami
chore: refactor usage of blockchainclient super trait
8f0ea5c
@shahnami
refactor: pass rpc client to process block handler and remove factory
56860a6
@shahnami
refactor: remove blockchainclientenum
ddc4c12
@shahnami
chore: merge from main
3ffb522
@shahnami
test: unwrap notifiers
52b2e41
@shahnami
chore: improve error handling for notification service
07b61d1
@shahnami
fix: trigger execution order
dfce4a1
@shahnami
chore: wrap client trait functions in retry logic
978bd32
@shahnami
chore: add test coverage reporting
03960e8
@shahnami
fix: ignore test files in coverage report
507d5e5
@shahnami
chore: add cargo clean to git hook
e5fe751
@collins-w
ci: add GitHub Actions workflow for Codecov integration
ae25ff5
@collins-w
ci: add codecov config file
314a225
@collins-w
ci: temporarily allow build trigger when pushed to integrate-codecov …
6215966 
…branch
@collins-w
fix: update Rust build flags to resolve profiling error
3f7258f
@collins-w
fix: try a different RS toolchain
8cfc774
@collins-w
fix: remove the unstable RS flagn
5a7f00c
@collins-w
chore: temporarily add upterm to ssh into the host ofr debugging purp…
ac08897 
…oses
@collins-w
chore: remove upterm
005ca5b
@collins-w
chore: temporarily add upterm to ssh into the host to debug zip
f850629
@collins-w
chore: verify test coverage
7aee8d3
shahnami
shahnami approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@shahnami shahnami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks :)

@codecov
Copy link

codecov bot commented Jan 24, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

tirumerla
tirumerla reviewed Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@tirumerla tirumerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work collins lgtm. Made some comments.

@shahnami shahnami added A-pipeline Filter, Trigger, Notification Services or CI pipeline P-high Critical tasks or blockers S-in-progress Actively being worked on T-task General tasks or chores (e.g., refactoring, cleanup) labels Jan 24, 2025
shahnami
shahnami approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@shahnami shahnami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tirumerla
tirumerla approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@tirumerla tirumerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm few comments

@tirumerla tirumerla merged commit 46cc496 into main Jan 24, 2025
16 checks passed
@tirumerla tirumerla deleted the integrate-codecov branch January 24, 2025 22:56
@shahnami shahnami added S-closed Completed and closed issues and removed S-in-progress Actively being worked on labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahnami shahnami shahnami approved these changes

@tirumerla tirumerla tirumerla approved these changes

@CoveMB CoveMB Awaiting requested review from CoveMB

@dylankilkenny dylankilkenny Awaiting requested review from dylankilkenny

@emnul emnul Awaiting requested review from emnul

@MCarlomagno MCarlomagno Awaiting requested review from MCarlomagno

@zeljkoX zeljkoX Awaiting requested review from zeljkoX

Assignees

No one assigned

Labels

A-pipeline Filter, Trigger, Notification Services or CI pipeline P-high Critical tasks or blockers S-closed Completed and closed issues T-task General tasks or chores (e.g., refactoring, cleanup)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@collins-w @shahnami @tirumerla @KitHat