-
Notifications
You must be signed in to change notification settings - Fork 29
chore: test run evm networks #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
======================================
Coverage 96.3% 96.3%
======================================
Files 78 78
Lines 25123 25229 +106
======================================
+ Hits 24199 24308 +109
+ Misses 924 921 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JeffreyJoel!
Just a few comments we need to verify.
Also, you will need to sign the CLA (through github bot) for us to merge your contributions
|
Okay, will make the changes |
|
I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution @JeffreyJoel!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks!
|
Hey @JeffreyJoel we notice the commits are not properly signed. Could you apply signatures to all commits? thanks! |
|
I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement |
@NicoMolinaOZ like this? |
Not exactly, we are enforcing commits with verified signatures. You can check this documentation: |
|
I'll have to rebase and sign the commits locally, should I go ahead? |
Thanks! |
Should I do anything else? |
Nop, it's Ok, thanks. |
Issue: #303
Summary
Checklist
I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement