Skip to content

Conversation

@JeffreyJoel
Copy link
Contributor

@JeffreyJoel JeffreyJoel commented Jul 15, 2025

Issue: #303

Summary

  • Test all the available evm networks
  • Add mainnet and testnets for avalanche, celo, scroll, linea, mantle and sonic networks

Checklist

  • Add a reference to related issues in the PR description.

I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.3%. Comparing base (f2d7953) to head (c49609a).
Report is 10 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main    #312    +/-   ##
======================================
  Coverage   96.3%   96.3%            
======================================
  Files         78      78            
  Lines      25123   25229   +106     
======================================
+ Hits       24199   24308   +109     
+ Misses       924     921     -3     
Flag Coverage Δ
integration 61.3% <ø> (+0.2%) ⬆️
properties 31.3% <ø> (-0.3%) ⬇️
unittests 86.3% <ø> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@shahnami shahnami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JeffreyJoel!

Just a few comments we need to verify.

Also, you will need to sign the CLA (through github bot) for us to merge your contributions

@JeffreyJoel
Copy link
Contributor Author

Okay, will make the changes

@JeffreyJoel
Copy link
Contributor Author

I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement

Copy link
Member

@shahnami shahnami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution @JeffreyJoel!

Copy link
Contributor

@NicoMolinaOZ NicoMolinaOZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@NicoMolinaOZ
Copy link
Contributor

Hey @JeffreyJoel we notice the commits are not properly signed. Could you apply signatures to all commits? thanks!

@JeffreyJoel
Copy link
Contributor Author

I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement

@JeffreyJoel
Copy link
Contributor Author

I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement

@NicoMolinaOZ like this?

@NicoMolinaOZ
Copy link
Contributor

I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement

@NicoMolinaOZ like this?

Not exactly, we are enforcing commits with verified signatures. You can check this documentation:
https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@JeffreyJoel
Copy link
Contributor Author

I'll have to rebase and sign the commits locally, should I go ahead?

@NicoMolinaOZ
Copy link
Contributor

I'll have to rebase and sign the commits locally, should I go ahead?

Thanks!

@JeffreyJoel
Copy link
Contributor Author

I'll have to rebase and sign the commits locally, should I go ahead?

Thanks!

Should I do anything else?

@NicoMolinaOZ
Copy link
Contributor

I'll have to rebase and sign the commits locally, should I go ahead?

Thanks!

Should I do anything else?

Nop, it's Ok, thanks.

@shahnami shahnami merged commit e839c9f into OpenZeppelin:main Jul 22, 2025
15 of 16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants