CLI: Support --exclude option#1065
Merged
ericglau merged 27 commits intoOpenZeppelin:masterfrom Aug 28, 2024
Merged
Conversation
Amxx
reviewed
Aug 28, 2024
Amxx
approved these changes
Aug 28, 2024
Contributor
Amxx
left a comment
There was a problem hiding this comment.
Left a very small suggestion. Looks good to me.
Co-authored-by: Hadrien Croubois <[email protected]>
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@nomicfoundation/[email protected]), npm/@openzeppelin/[email protected]), npm/@openzeppelin/[email protected]), npm/@openzeppelin/[email protected]), npm/@openzeppelin/[email protected]), npm/@openzeppelin/[email protected]) |
This was referenced May 7, 2025
This was referenced May 20, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
--exclude "<GLOB_PATTERN>" [--exclude "<GLOB_PATTERN>"...]option to the CLI, which allows glob patterns of source file paths that should be excluded from the validation report. If passing in multiple patterns, call the option multiple times, once for each pattern.This supports any of the user's source files or their dependencies. Note this only supports file paths (e.g. the paths of
.solfiles), not the names of specific contracts in those files.Additional notes:
--contract <CONTRACT_NAME>option was specified and the file is excluded via the--excludeoption, an error will be thrown.**/contracts/proxy/beacon/UpgradeableBeacon.solis always added to theexcludelist automatically, sinceUpgradeableBeaconcontains anupgradeTo(address)function and is incorrectly detected as an implementation contract.--referenceBuildInfoDirsand--unsafeAllowoptions to support those options being called either with a comma (as before) or multiple times (introduced in this PR).--excludedoes not treat comma as a delimiter, because globs can have commas within them e.g.--exclude "**/{A,B}.sol"Fixes #1035
Fixes #849