Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HRMP Channel Guide #214

Merged
merged 20 commits into from
Jul 30, 2024
Merged

HRMP Channel Guide #214

merged 20 commits into from
Jul 30, 2024

Conversation

4meta5
Copy link
Contributor

@4meta5 4meta5 commented May 31, 2024

Closes #190

Examples:

  • AssetHub
  • Snowbridge
  • HydraDX

follow up

#269

@4meta5 4meta5 added the documentation Improvements or additions to documentation label May 31, 2024
@4meta5 4meta5 added this to the Deliverable 2 - EVM template milestone May 31, 2024
@4meta5 4meta5 self-assigned this May 31, 2024
Copy link

netlify bot commented May 31, 2024

Deploy Preview for docs-oz-polkadot ready!

Name Link
🔨 Latest commit 3300e7b
🔍 Latest deploy log https://app.netlify.com/sites/docs-oz-polkadot/deploys/665a3abe8f4ec700084c2c63
😎 Deploy Preview https://deploy-preview-214--docs-oz-polkadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 31, 2024

Deploy Preview for docs-oz-polkadot canceled.

Name Link
🔨 Latest commit 096289c
🔍 Latest deploy log https://app.netlify.com/sites/docs-oz-polkadot/deploys/66a24d5d1668a4000954b689

@4meta5 4meta5 marked this pull request as ready for review May 31, 2024 21:25
@KitHat
Copy link
Member

KitHat commented Jun 6, 2024

A guide looks good to me, but it is not what was really wanted from the task. Could you please add more data about the proposals that you need to make to open the channels? Including some proposals as an example, like this one for the Unique Network <-> Asset Hub channel proposal

@4meta5
Copy link
Contributor Author

4meta5 commented Jun 6, 2024

Agreed, in fact this PR is on hold until #215 is implemented because otherwise the examples cannot match the ones in the issue.

@4meta5 4meta5 added on hold Pending other work or discussion labels Jun 6, 2024
@4meta5 4meta5 removed the on hold Pending other work or discussion label Jun 19, 2024
@4meta5 4meta5 requested a review from KitHat July 15, 2024 22:15
ggonzalez94 and others added 3 commits July 19, 2024 06:27
* add sync fast-unsafe for Rococo

* fix spelling

* add descriptions for datadir path and rococo chainspec
* Fix MaxLockers

* fix constants

* fix toolchains

---------

Co-authored-by: Özgün Özerk <[email protected]>
@DrW3RK
Copy link
Contributor

DrW3RK commented Jul 24, 2024

HRMP channel guide for Asset Hub, and in fact all system chains can benefit from this update

image

https://paritytech.github.io/polkadot-sdk/master/polkadot_runtime_parachains/hrmp/pallet/dispatchables/fn.establish_channel_with_system.html

We were successfully able to open a bi-directional channel to Rococo Asset Hub from https://web3educhain.xyz/ built with OpenZeppelin template.

image

@4meta5 4meta5 changed the base branch from main to v2 July 25, 2024 13:16
@4meta5 4meta5 requested review from ozgunozerk and removed request for KitHat and ozgunozerk July 25, 2024 13:21
@4meta5
Copy link
Contributor Author

4meta5 commented Jul 25, 2024

Moving suggestion completion to follow up: #214 (comment)

@4meta5 4meta5 requested review from KitHat and ozgunozerk July 30, 2024 14:44
Copy link
Member

@KitHat KitHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix the lists in the doc. In other things, everything is great!

Copy link
Collaborator

@ozgunozerk ozgunozerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful! 💯

@DrW3RK
Copy link
Contributor

DrW3RK commented Jul 30, 2024

Here is the PR on the Wiki that updates the outdated instructions for establishing channel with Asset Hub. https://github.com/w3f/polkadot-wiki/pull/6116/files

@4meta5 4meta5 merged commit 414e9eb into v2 Jul 30, 2024
@4meta5 4meta5 deleted the amar-hrmp-connect-docs branch July 30, 2024 21:04
ggonzalez94 added a commit that referenced this pull request Aug 7, 2024
* init

* clean

* add minimal handler docs

* connect to asset hub section

* progress but not done

* start snowbridge calls

* snowbridge docs

* hydraDX documentation to demonstrate steps from the more general hrmp section at the tope

* Add the option to sync faster with Rococo to the docs (#249)

* add sync fast-unsafe for Rococo

* fix spelling

* add descriptions for datadir path and rococo chainspec

* Fix MaxLockers (#248)

* Fix MaxLockers

* fix constants

* fix toolchains

---------

Co-authored-by: Özgün Özerk <[email protected]>

* fix list bullet formatting

* accept all suggestions by @ozgunozerk

---------

Co-authored-by: Gustavo Gonzalez <[email protected]>
Co-authored-by: Nikita Khateev <[email protected]>
Co-authored-by: Özgün Özerk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

🏗️ [Core Feature]: XCM connections to other parachains
5 participants