[Feature]: ERC721Wrapper extension #1854
Annotations
6 warnings
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Cargo clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L54
[clippy] reported by reviewdog 🐶
warning: unused variable: `length`
--> contracts/src/token/erc721/extensions/wrapper.rs:54:13
|
54 | let length = token_ids.len();
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_length`
|
= note: `#[warn(unused_variables)]` on by default
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:54:13:w:warning: unused variable: `length`
--> contracts/src/token/erc721/extensions/wrapper.rs:54:13
|
54 | let length = token_ids.len();
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_length`
|
= note: `#[warn(unused_variables)]` on by default
__END__
|
Cargo clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L51
[clippy] reported by reviewdog 🐶
warning: unused variable: `account`
--> contracts/src/token/erc721/extensions/wrapper.rs:51:9
|
51 | account: Address,
| ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_account`
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:51:9:w:warning: unused variable: `account`
--> contracts/src/token/erc721/extensions/wrapper.rs:51:9
|
51 | account: Address,
| ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_account`
__END__
|
Cargo clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L52
[clippy] reported by reviewdog 🐶
warning: this argument is passed by value, but not consumed in the function body
--> contracts/src/token/erc721/extensions/wrapper.rs:52:20
|
52 | token_ids: Vec<U256>,
| ^^^^^^^^^ help: consider changing the type to: `&[U256]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
= note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]`
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:52:20:w:warning: this argument is passed by value, but not consumed in the function body
--> contracts/src/token/erc721/extensions/wrapper.rs:52:20
|
52 | token_ids: Vec<U256>,
| ^^^^^^^^^ help: consider changing the type to: `&[U256]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
= note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]`
__END__
|
Cargo clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L60
[clippy] reported by reviewdog 🐶
warning: this method could have a `#[must_use]` attribute
--> contracts/src/token/erc721/extensions/wrapper.rs:60:5
|
60 | pub fn underlying(&self) -> &Erc721 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn underlying(&self) -> &Erc721`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
= note: `-W clippy::must-use-candidate` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::must_use_candidate)]`
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:60:5:w:warning: this method could have a `#[must_use]` attribute
--> contracts/src/token/erc721/extensions/wrapper.rs:60:5
|
60 | pub fn underlying(&self) -> &Erc721 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn underlying(&self) -> &Erc721`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
= note: `-W clippy::must-use-candidate` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::must_use_candidate)]`
__END__
|
Cargo clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L61
[clippy] reported by reviewdog 🐶
warning: used underscore-prefixed binding
--> contracts/src/token/erc721/extensions/wrapper.rs:61:10
|
61 | &self._underlying
| ^^^^^^^^^^^^^^^^
|
note: binding is defined here
--> contracts/src/token/erc721/extensions/wrapper.rs:20:5
|
20 | pub _underlying: Erc721,
| ^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#used_underscore_binding
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:61:10:w:warning: used underscore-prefixed binding
--> contracts/src/token/erc721/extensions/wrapper.rs:61:10
|
61 | &self._underlying
| ^^^^^^^^^^^^^^^^
|
note: binding is defined here
--> contracts/src/token/erc721/extensions/wrapper.rs:20:5
|
20 | pub _underlying: Erc721,
| ^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#used_underscore_binding
__END__
|
Loading