Skip to content

fix(M-01): Erc165 standard support #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

qalisander
Copy link
Member

@qalisander qalisander commented Oct 4, 2024

Resolves: #319

PR Checklist

  • Tests
  • Documentation

@qalisander
Copy link
Member Author

qalisander commented Oct 4, 2024

Erc165 depends on the new workspace structure. To not have many conflicts I've pulled that commit also.
Second thing @ggonzalez94 is how check link pipeline should work with not published yet changes?
Seems we should always have antora documentation added as a second pr

@qalisander qalisander force-pushed the fix-M-01-erc165-support branch from 89ee202 to 762a0e5 Compare October 4, 2024 08:32
@qalisander qalisander requested a review from ggonzalez94 October 4, 2024 11:29
@qalisander qalisander marked this pull request as ready for review October 4, 2024 11:30
@qalisander qalisander requested a review from bidzyyys as a code owner October 4, 2024 11:30
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

bidzyyys and others added 2 commits October 9, 2024 23:11
- [x]  Set `motsu` version to `v0.1.0`
- [x] Improve version management for the workspace
- `contracts`, `lib/crypto`, `examples`, and `benches` use version set
for the whole workspace
- `motsu`, `motsu-proc`, `e2e`, `e2e-proc` have their own version per
crate
- [x] Cleanup dependencies for the workspace
- [x] Add CI checks for pre-publishing on crates.io
- [x] Fix issues with publishing `motsu` to crates.io:
```
cargo publish -p motsu --target wasm32-unknown-unknown --dry-run
    Updating crates.io index
error: all dependencies must have a version specified when publishing.
dependency `motsu-proc` does not specify a version
Note: The published dependency will use the version from crates.io,
the `path` specification will be removed from the dependency declaration.
```

---------

(cherry picked from commit b1eef80)
Adds erc165 standard altogether with a proc macro, that lets to compute
interface id in a simple way.

<!-- Fill in with issue number -->
Resolves #33

#### PR Checklist

- [x] Tests
- [x] Documentation

---------

Co-authored-by: Daniel Bigos <[email protected]>
(cherry picked from commit 9b04143)
@qalisander qalisander force-pushed the fix-M-01-erc165-support branch from 762a0e5 to 85062b8 Compare October 9, 2024 19:13
@ggonzalez94 ggonzalez94 merged commit 4106d03 into v0.1.0 Oct 14, 2024
20 checks passed
@bidzyyys bidzyyys deleted the fix-M-01-erc165-support branch October 15, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Audit]: M-01 ERC-721 Does Not Support ERC-165
3 participants