Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: ERC721Wrapper extension #461

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Feature]: ERC721Wrapper extension #461

wants to merge 1 commit into from

Conversation

programskillforverification
Copy link
Contributor

Resolves #359

PR Checklist

  • Tests
  • Documentation
  • Changelog

@netlify Netlify
Copy link

netlify bot commented Dec 17, 2024 •
edited
Loading

✅ Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit ed85c4c
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/6760f0fb7259de0008fd318f

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 89.4%. Comparing base (da0249b) to head (ed85c4c).

Files with missing lines Patch % Lines
contracts/src/token/erc721/extensions/wrapper.rs 0.0% 31 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
contracts/src/token/erc721/extensions/wrapper.rs 0.0% <0.0%> (ø)

programskillforverification
programskillforverification commented Dec 17, 2024
View reviewed changes
contracts/src/token/erc721/extensions/wrapper.rs
#[storage]
pub struct Erc721Wrapper {
/// Erc721 contract storage.
pub _underlying: Erc721,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bidzyyys What should the type of _underlying be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidzyyys bidzyyys Awaiting requested review from bidzyyys bidzyyys will be requested when the pull request is marked ready for review bidzyyys is a code owner

@qalisander qalisander Awaiting requested review from qalisander qalisander will be requested when the pull request is marked ready for review qalisander is a code owner

@0xNeshi 0xNeshi Awaiting requested review from 0xNeshi 0xNeshi will be requested when the pull request is marked ready for review 0xNeshi is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: ERC721Wrapper extension
1 participant
@programskillforverification