Skip to content

feat: ERC721Wrapper extension#461

Merged
0xNeshi merged 45 commits intoOpenZeppelin:mainfrom
programskillforverification:erc721-wrapper
Apr 4, 2025
Merged

feat: ERC721Wrapper extension#461
0xNeshi merged 45 commits intoOpenZeppelin:mainfrom
programskillforverification:erc721-wrapper

Conversation

@programskillforverification
Copy link
Contributor

@programskillforverification programskillforverification commented Dec 17, 2024

Resolves #359

PR Checklist

  • Tests
  • Documentation
  • Changelog

@netlify
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit 56a2f0f
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/67ef91ee80a4890008999198

@codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 89.3%. Comparing base (3205fc7) to head (195ced3).

Files with missing lines Patch % Lines
contracts/src/token/erc721/extensions/wrapper.rs 0.0% 31 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
contracts/src/token/erc721/extensions/wrapper.rs 0.0% <0.0%> (ø)

@bidzyyys
Copy link
Collaborator

Hey @programskillforverification!
Are you going to finish the implementation or should we unassigned the issue from you?

@programskillforverification
Copy link
Contributor Author

Hey @programskillforverification! Are you going to finish the implementation or should we unassigned the issue from you?

I am going to finish this implementation and commit immediately once my vocation end up.

@bidzyyys
Copy link
Collaborator

Hey @programskillforverification! Are you going to finish the implementation or should we unassigned the issue from you?

I am going to finish this implementation and commit immediately once my vocation end up.

Oh, okay, enjoy your time-off!
Let us know if you need any help with this contract.

@0xNeshi 0xNeshi self-requested a review January 30, 2025 09:17
@bidzyyys bidzyyys changed the title [Feature]: ERC721Wrapper extension feat: ERC721Wrapper extension Mar 27, 2025
@bidzyyys bidzyyys marked this pull request as ready for review April 1, 2025 00:06
@bidzyyys bidzyyys requested a review from qalisander as a code owner April 1, 2025 00:06
@bidzyyys bidzyyys requested a review from 0xNeshi April 1, 2025 22:48
@bidzyyys bidzyyys mentioned this pull request Apr 2, 2025
3 tasks

use stylus_sdk::prelude::sol_interface;
sol_interface! {
interface Erc20Interface {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better. Although it's still a bit confusing, it should be ok for now.

@qalisander do you have any alternative name suggestions for sol interfaces?
See previous comment for context.

@bidzyyys bidzyyys requested a review from 0xNeshi April 3, 2025 14:41
Copy link
Collaborator

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 🚀

@0xNeshi 0xNeshi merged commit c8b7b61 into OpenZeppelin:main Apr 4, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: ERC721Wrapper extension

3 participants