Erc4626 extension

[Ifechukwudaniel]

Resolves #356

PR Checklist

• Tests
• Documentation
• Changelog

[netlify]

✅ Deploy Preview for contracts-stylus canceled.

Name	Link
🔨 Latest commit	17e6d42
🔍 Latest deploy log	https://app.netlify.com/sites/contracts-stylus/deploys/67828bde4ca78a000870a9d1

[Ifechukwudaniel]

I just stared this

[0xNeshi]

I'll convert this to a draft, so that the team does not invest time reviewing a WIP

[Ifechukwudaniel]

@0xNeshi
The Solidity implementation uses safe transfer

SafeERC20.safeTransferFrom(_asset, caller, address(this), assets);

In the Solidity implementation, SafeERC20 is a utility library. However, in the Stylus implementation, SafeTransfer is a contract. What do you think

[0xNeshi]

@0xNeshi The Solidity implementation uses safe transfer

SafeERC20.safeTransferFrom(_asset, caller, address(this), assets);

In the Solidity implementation, SafeERC20 is a utility library. However, in the Stylus implementation, SafeTransfer is a contract. What do you think

See how VestingWallet handles this

[codecov]

Codecov Report

Attention: Patch coverage is 23.78641% with 157 lines in your changes missing coverage. Please review.

Project coverage is 86.2%. Comparing base (6210620) to head (d486031).

Files with missing lines	Patch %	Lines
contracts/src/token/erc20/extensions/erc4626.rs	23.7%	157 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
contracts/src/token/erc20/extensions/erc4626.rs	23.7% <23.7%> (ø)

[Ifechukwudaniel]

@0xNeshi what do you think about this current approach

[0xNeshi]

Hi @Ifechukwudaniel, you should follow the originally proposed approach, see #465 (comment)