Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add missing E2E tests for Erc721 #489

Merged
merged 15 commits into from
Jan 14, 2025
Merged

test: add missing E2E tests for Erc721 #489

merged 15 commits into from
Jan 14, 2025

Conversation

DarkLord017
Copy link
Contributor

@DarkLord017 DarkLord017 commented Jan 11, 2025 •
edited
Loading

Resolves #483

PR Checklist

  • Tests
  • Documentation
  • Changelog

@netlify Netlify
Copy link

netlify bot commented Jan 11, 2025 •
edited
Loading

✅ Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit 72175c6
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/67865ab663cdd20008e96308

@DarkLord017 DarkLord017 marked this pull request as ready for review January 11, 2025 11:09
@DarkLord017
Copy link
Contributor Author

Added tests regarding ERC721 _safe_Mint

0xNeshi
0xNeshi reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work @DarkLord017 !
Left mostly some nits to address

examples/erc721/src/lib.rs Outdated Show resolved Hide resolved
examples/erc721/tests/abi/mod.rs Outdated Show resolved Hide resolved
examples/erc721/tests/erc721.rs Outdated Show resolved Hide resolved
examples/erc721/tests/erc721.rs Outdated Show resolved Hide resolved
examples/erc721/tests/erc721.rs Outdated Show resolved Hide resolved
examples/erc721/tests/erc721.rs Outdated Show resolved Hide resolved
examples/erc721/tests/erc721.rs Outdated Show resolved Hide resolved
examples/erc721/tests/erc721.rs Outdated Show resolved Hide resolved
examples/erc721/tests/erc721.rs Outdated Show resolved Hide resolved
examples/erc721/tests/erc721.rs Outdated Show resolved Hide resolved
@bidzyyys bidzyyys changed the title Safe mint tests test: add missing E2E tests for Erc721 Jan 13, 2025
@DarkLord017
Copy link
Contributor Author

@0xNeshi you can review it now

@DarkLord017 DarkLord017 requested a review from 0xNeshi January 14, 2025 08:10
0xNeshi
0xNeshi reviewed Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, almost ready to merge

examples/erc721/tests/erc721.rs Outdated Show resolved Hide resolved
examples/erc721/tests/erc721.rs Outdated Show resolved Hide resolved
examples/erc721/tests/erc721.rs Outdated Show resolved Hide resolved
examples/erc721/tests/erc721.rs Outdated Show resolved Hide resolved
@DarkLord017
Copy link
Contributor Author

@0xNeshi you can review it now

0xNeshi
0xNeshi approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work!
I cleaned some things up, and the PR LGTM 🚀

Feel free to pick up a new issue to work on, we'd be more than happy to have you help us out!

@bidzyyys bidzyyys self-requested a review January 14, 2025 12:38
bidzyyys
bidzyyys approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @DarkLord017!

@bidzyyys bidzyyys merged commit badee40 into OpenZeppelin:main Jan 14, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xNeshi 0xNeshi 0xNeshi approved these changes

@bidzyyys bidzyyys bidzyyys approved these changes

@qalisander qalisander Awaiting requested review from qalisander qalisander is a code owner

Assignees

@DarkLord017 DarkLord017

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Add Missing Erc721 E2E Tests
3 participants
@DarkLord017 @0xNeshi @bidzyyys