Skip to content

fix: make event_assert crate handle multiple events in sequence #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 16, 2025

Conversation

YanVictorSN
Copy link
Contributor

Fixes #123

This PR changes how the find_event_by_symbol from EventAssertion handles multiple events in sequence. To achieve this, we introduced a HashSet called processed_events to keep track of the indices of the events that have already been read.

PR Checklist

  • Tests
  • Documentation

Copy link

netlify bot commented Apr 14, 2025

Deploy Preview for delightful-dieffenbachia-2097e0 canceled.

Name Link
🔨 Latest commit 67f089e
🔍 Latest deploy log https://app.netlify.com/sites/delightful-dieffenbachia-2097e0/deploys/67ff530a3d501e0008ef304a

@ozgunozerk
Copy link
Collaborator

ozgunozerk commented Apr 15, 2025

Very straight forward, and works! Love it ♥️

@YanVictorSN
Copy link
Contributor Author

Very straight forward, and works! Love it ♥️

Thank you! I followed your suggestion to keep it simple. <3

@ozgunozerk ozgunozerk self-requested a review April 16, 2025 06:58
@ozgunozerk ozgunozerk merged commit 45092e3 into OpenZeppelin:main Apr 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 [Bug]: Event Assertion create only handles the first error of a kind
2 participants