refactor access control errors

[ozgunozerk]

Fixes #285

Note: this one is important, it does some refactoring. Namely:

• get_admin signature is changed to return an option, and not return an error, due to we added admin removal functionality ([M-03] Missing Functionality to Renounce Admin #259)

PR Checklist

• Tests
• Documentation

[netlify]

✅ Deploy Preview for delightful-dieffenbachia-2097e0 canceled.

Name	Link
🔨 Latest commit	86d038d
🔍 Latest deploy log	https://app.netlify.com/projects/delightful-dieffenbachia-2097e0/deploys/685ff1ccea6ff100082cdbbe

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.03%. Comparing base (04bb54b) to head (86d038d).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/access/access-control/src/storage.rs	80.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   98.06%   98.03%   -0.04%     
==========================================
  Files          64       64              
  Lines        5586     5586              
==========================================
- Hits         5478     5476       -2     
- Misses        108      110       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[brozorec]

I just did the opposite for get_owner() in #317 ...

[ozgunozerk]

I just did the opposite for get_owner() in #317 ...

Oh that's unfortunate, sorry to hear that!

But I think they should both return option instead of panicking, since we have renounce mechanism present.

[brozorec]

Approving this one but after the conflicts get resolved (test_sac_generic must be the one from main), the new errors must be covered in tests.

[ozgunozerk]

the new errors must be covered in tests.

they were already covered! 👍