-
Notifications
You must be signed in to change notification settings - Fork 12
feat: remove Context::init
helper (#101)
#102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove Context::init
helper (#101)
#102
Conversation
* feat: remove `Context::init` helper This commit removes the `Context::init` helper function. The `Context::init` helper is replaced by contract constructors. * docs: update CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just make this one change and we can merge
CHANGELOG.md
Outdated
@@ -9,6 +9,9 @@ The format is based on [Keep a Changelog], and this project adheres to [Semantic | |||
|
|||
## [Unreleased] | |||
|
|||
### Removed | |||
- `Context::init` helper (replaced by contract constructors – see issue #101) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current convention is to place any removals under Changed (Breaking)
. Also, add number of the PR in which this was introduced (see other logs here as example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thankyou for the review. Fixed in this commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR removes the obsolete
Context::init
testing helper, now redundant thanks to Stylus contract constructors.init
Resolves #101
PR Checklist