feat: add method to get all events emitted by the contract #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isSerge
requested review from
bidzyyys,
qalisander,
0xNeshi and
ggonzalez94
as code owners
|
Hi @isSerge and thanks for the contribution. We are currently under a huge workload, so we will be reviewing the PR as soon as we can. |
0xNeshi
reviewed
Jun 6, 2025
Co-authored-by: Nenad <[email protected]>
…ccumulation order
Co-authored-by: Nenad <[email protected]>
bidzyyys
reviewed
Jun 10, 2025
crates/motsu/src/lib.rs
Outdated
| let events_after_two_calls = ping.all_events(); | ||
| assert_eq!(events_after_two_calls.len(), 2, "Should be 2 events"); | ||
|
|
||
| // Second call to all_events immediately after |
There was a problem hiding this comment.
Suggested change
| // Second call to all_events immediately after | |
| // Second call to `all_events` immediately after. |
crates/motsu/src/lib.rs
Outdated
| "Repeated calls after two events should be consistent" | ||
| ); | ||
|
|
||
| // Check content of the two events |
There was a problem hiding this comment.
Suggested change
| // Check content of the two events | |
| // Check content of the two events. |
crates/motsu/src/lib.rs
Outdated
| "Second event should be correct" | ||
| ); | ||
|
|
||
| // Perform a read-only operation that doesn't emit events |
There was a problem hiding this comment.
Suggested change
| // Perform a read-only operation that doesn't emit events | |
| // Perform a read-only operation that does not emit events. |
crates/motsu/src/lib.rs
Outdated
| // Perform a read-only operation that doesn't emit events | ||
| let _pings_count = ping.sender(alice).pings_count.get(); | ||
|
|
||
| // Third call to all_events after a read operation |
There was a problem hiding this comment.
Suggested change
| // Third call to all_events after a read operation | |
| // Third call to `all_events` after a read operation. |
bidzyyys
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #55
PR Checklist