fix: correct devtools and fix app scripts #142
Merged
+36
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We tried to get nice readable scripts and environments in the app runscript and systemd unit and it didn't work and it's because of the sed thing and that's stupid so just write these values down in the files and check them in. Also fix the devtools allow-origin to be pluralized so it actually works.
sfoster1
commented
Apr 4, 2024
|
|
||
| /opt/opentrons-app/opentrons \ | ||
| --disable-gpu \ | ||
| --remote-allow-origins=* \ |
There was a problem hiding this comment.
this specifically is what was breaking devtools, this wasn't pluralized
vegano1
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried to get nice readable scripts and environments in the app runscript and systemd unit and it didn't work and it's because of the sed thing and that's stupid so just write these values down in the files and check them in.
Also fix the devtools allow-origin to be pluralized so it actually works.
https://opentrons.atlassian.net/browse/AUTH-285