Skip to content

feat(api): Differenciate motion settings between 96ch 200 and 1000 #18552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: edge
Choose a base branch
from

Conversation

ryanthecoder
Copy link
Contributor

Overview

Hardware testing/lifetime has found that the 96ch 200 will likely need different motion settings. The way we split it currently is 96ch and everything else (which is due to the fact that the 96ch's have the same motor and the singles/multis share a motor) however the vast difference in friction force in the two 96ch will likely require different tuning.
This PR lays the framework for differentiating between the two different settings. It doesn't yet change any of the settings.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@ryanthecoder ryanthecoder requested review from a team as code owners June 6, 2025 14:47
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.82%. Comparing base (cb51d1b) to head (fd356e5).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #18552   +/-   ##
=======================================
  Coverage   24.82%   24.82%           
=======================================
  Files        3273     3273           
  Lines      281047   281047           
  Branches    33831    33831           
=======================================
  Hits        69780    69780           
  Misses     211246   211246           
  Partials       21       21           
Flag Coverage Δ
protocol-designer 19.29% <ø> (ø)
step-generation 4.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's add some tests that actually specify the 200 gantry load please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants