Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use native http module instead of request dependency #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

endel
Copy link

@endel endel commented Mar 29, 2019

I've found redbird today, and was going to test it, but noticed that redbird has too many dependencies. dolphin/request being one of them.

This pull-request just removes request, as it has 20 dependencies only for using GET + JSON parsing.

See the dependency graph below:

Screenshot 2019-03-29 at 15 31 07

And now, without request:

Screenshot 2019-03-29 at 15 53 18

@endel
Copy link
Author

endel commented Mar 29, 2019

BTW, I couldn't run the unit tests. I'd appreciate if you can validate if this change doesn't break anything 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant