Skip to content

Navbar: Allow flex-grow on each .navbar-collapse #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Navbar: Allow flex-grow on each .navbar-collapse #1528

wants to merge 9 commits into from

Conversation

@louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Sep 9, 2022 •
edited
Loading

Fixes #1514.

Some few changes that'd allow to have flex-grow. This might have some breaking changes in the markup but I can't see any visual regression.

Might simplify a bit the markup and I think it would be way better this way and also be closer to Bootstrap.

@louismaximepiton louismaximepiton added v5 📖 documentation Improvements or additions to documentation fix css 🧩 enhancement labels Sep 9, 2022
@netlify
Copy link

netlify bot commented Sep 9, 2022 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 3eb4d96
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6596788b6d473100088e9425
😎 Deploy Preview https://deploy-preview-1528--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

MewenLeHo
MewenLeHo reviewed Sep 13, 2022
View reviewed changes
MewenLeHo
MewenLeHo reviewed Sep 13, 2022
View reviewed changes
MewenLeHo
MewenLeHo reviewed Sep 13, 2022
View reviewed changes
Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good but some problems on smaller resolutions

@MewenLeHo
Copy link
Contributor

MewenLeHo commented Nov 23, 2022

Good but some problems on smaller resolutions

The actual behaviour is the desired behaviour so ok form me 🚀

MewenLeHo
MewenLeHo approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond

This comment was marked as resolved.

Sign in to view
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MewenLeHo MewenLeHo MewenLeHo approved these changes

Assignees

No one assigned

Labels

css 📖 documentation Improvements or additions to documentation 🧩 enhancement fix v5

Projects

🟣 [Orange-Boosted-Bootstrap] PRs Board
Status: Need Lead Dev Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Right alignment in Navar text example

3 participants

@louismaximepiton @MewenLeHo @julien-deramond