Skip to content

Navbar: Allow flex-grow on each .navbar-collapse#1528

Closed
louismaximepiton wants to merge 9 commits intomainfrom
main-lmp-navbar-flex-grow-fix
Closed

Navbar: Allow flex-grow on each .navbar-collapse#1528
louismaximepiton wants to merge 9 commits intomainfrom
main-lmp-navbar-flex-grow-fix

Conversation

@louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Sep 9, 2022

Fixes #1514.

Some few changes that'd allow to have flex-grow. This might have some breaking changes in the markup but I can't see any visual regression.

Might simplify a bit the markup and I think it would be way better this way and also be closer to Bootstrap.

@louismaximepiton louismaximepiton added v5 📖 documentation Improvements or additions to documentation fix css 🧩 enhancement labels Sep 9, 2022
@netlify
Copy link

netlify bot commented Sep 9, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 3eb4d96
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6596788b6d473100088e9425
😎 Deploy Preview https://deploy-preview-1528--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good but some problems on smaller resolutions

@MewenLeHo
Copy link
Contributor

Good but some problems on smaller resolutions

The actual behaviour is the desired behaviour so ok form me 🚀

Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond

This comment was marked as resolved.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vprothais vprothais added this to the Boosted shelf milestone Dec 9, 2025
@vprothais
Copy link
Collaborator

I close this PR after adding it to "Boosted shelf" Milestone to keep track of existing PR on Boosted if needed.

@vprothais vprothais closed this Dec 10, 2025
@github-project-automation github-project-automation bot moved this from Need Lead Dev Review to Done in 🟣 [Orange-Boosted-Bootstrap] PRs Board Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css 📖 documentation Improvements or additions to documentation 🧩 enhancement fix v5

Projects

Development

Successfully merging this pull request may close these issues.

Right alignment in Navar text example

4 participants