-
Notifications
You must be signed in to change notification settings - Fork 57
Fix pagination: make previous and next buttons accessible #2102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 27 commits
9460019
4699306
55de330
bfb234f
f6d4185
9217af7
23bd2e7
02ef7e5
48886f6
48a954a
bfc5da4
812cf89
aa2f7fa
1aaa90a
69b1bef
9a352c8
04c86fd
4d151ad
9d8ad6c
6f753db
7992576
fb02b56
0a5b410
ba98b65
026d259
d57ee5e
15f3d6b
346f5ab
95c9c68
1a00d11
f7093fb
54523a8
eec7fb1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1577,8 +1577,9 @@ $dropdown-dark-header-color: $white !default; // Boosted mod | |
| // Pagination | ||
|
|
||
| // scss-docs-start pagination-variables | ||
| $pagination-padding-y: null !default; | ||
| $pagination-padding-x: null !default; | ||
| $pagination-padding-y: .5625rem !default; // Boosted mod: instead of `null` | ||
| $pagination-padding-x: .8125rem !default; // Boosted mod: instead of `null` | ||
| $pagination-label-padding-x: 1.125rem !default; // Boosted mod | ||
|
|
||
| $pagination-font-size: $font-size-base !default; | ||
|
|
||
|
|
@@ -1614,15 +1615,21 @@ $pagination-transition: $transition-focus !default; | |
| // Boosted mod: no $pagination-border-radius-lg | ||
|
|
||
| // Boosted mod | ||
| $pagination-padding-end: 1.125rem !default; | ||
| $pagination-icon: var(--#{$prefix}chevron-icon) !default; | ||
| $pagination-icon-size: subtract($spacer * 2, calc(var(--#{$prefix}border-width) * 2)) !default; // stylelint-disable-line function-disallowed-list | ||
| $pagination-icon-min-width: .625rem !default; | ||
| $pagination-icon-size: 1.125rem !default; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These two should be named almost the same since their goal is the same. Maybe something like
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Something like
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't have any idea on how to call those. Let's wait for the last review to decide ?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it will be a job for the lead dev review 😉 Simple reminder: changing the name of |
||
| $pagination-icon-width: add(.5rem, 1px) !default; | ||
| $pagination-icon-height: subtract(1rem, 1px) !default; | ||
| $pagination-gap: 5px !default; | ||
|
|
||
| $pagination-active-item-bg: $primary !default; | ||
| $pagination-active-item-color: color-contrast($pagination-active-item-bg) !default; | ||
| $pagination-active-item-border: $pagination-active-item-bg !default; | ||
|
|
||
| $pagination-item-max-width: $spacer * .5 !default; | ||
| // fusv-disable | ||
| $pagination-padding-end: 1.125rem !default; // Deprecated in Boosted 5.3.0 for responsive pagination | ||
louismaximepiton marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| // fusv-enable | ||
louismaximepiton marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // End mod | ||
| // scss-docs-end pagination-variables | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.