Dark mode: Stepped process#2273
Merged
julien-deramond merged 52 commits intomain-jd-dark-modefrom Oct 3, 2023
Merged
Conversation
julien-deramond
changed the base branch from
main-jd-dark-mode
to
main-jd-dark-mode-drop-dark-variants
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
changed the title
hannahiss
changed the base branch from
main-jd-dark-mode-drop-dark-variants
to
main-jd-dark-mode
hannahiss
changed the base branch from
main-jd-dark-mode
to
main-jd-dark-mode-drop-dark-variants
Contributor
julien-deramond
left a comment
julien-deramond
left a comment
There was a problem hiding this comment.
Minor comments and we're good to go for this first version of semi-complex component
julien-deramond
added
the
color mode
julien-deramond
force-pushed
the
main-jd-dark-mode-drop-dark-variants
branch
from
bb078d6 to
36cb3f0
Compare
…k-mode-stepped-process # Conflicts: # scss/_variables.scss
…m Franco) and intermediary sass variable
…d bs-link-color in dark mode test page
Co-authored-by: Louis-Maxime Piton <[email protected]>
Co-authored-by: Louis-Maxime Piton <[email protected]>
Co-authored-by: Louis-Maxime Piton <[email protected]>
…k-mode-stepped-process
…k-mode-stepped-process
…component bg (specially arrows between steps)
Base automatically changed from
main-jd-dark-mode-drop-dark-variants
to
main-jd-dark-mode
October 3, 2023 09:12
# Conflicts: # site/content/docs/5.3/components/navbar.md # site/layouts/shortcodes/callout-deprecated-dark-variants.html
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stepped process in dark mode, by using existing css vars :
$step-item-bg:--bs-highlight-bg- to switch from black to white ---bs-highlight-bgto be noted)$step-item-next-bg:--bs-border-color-translucent- to switch from#cccto#666---bs-border-color-translucentto be noted)$step-item-drop-shadow: using--bs-stepped-process-bgwhich is equal to--bs-body-bg- to switch from white to black$step-link-color:--bs-link-color- to switch from black to white$step-link-next-color:--bs-link-color- to switch from black to white#dddto#cccby this PR--bs-stepped-process-bgequals to--bs-body-bgbut ca,n be changed by users--bs-stepped-process-bgLinks