fix(unit tests): drop .btn-secondary from carousel play/pause buttons#2306
Merged
julien-deramond merged 2 commits intomainfrom Oct 12, 2023
Merged
fix(unit tests): drop .btn-secondary from carousel play/pause buttons#2306julien-deramond merged 2 commits intomainfrom
.btn-secondary from carousel play/pause buttons#2306julien-deramond merged 2 commits intomainfrom
Conversation
33 tasks
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
louismaximepiton
approved these changes
Oct 12, 2023
Member
louismaximepiton
left a comment
There was a problem hiding this comment.
It's not exactly the carousel's actual markup since the pause button is contained inside the carousel but I'm fine with the changes since it passes tests
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR suggests changing the markup used to render the play/pause buttons in carousels' unit tests so that they use the same one as in https://boosted.orange.com/docs/5.3/components/carousel/#with-pauseplay-button:
It basically means to drop the use of
.btn-secondary.Note: it'll help with the work in progress in #2223
Motivation & Context
Consistency between the carousels' markups.
Types of change
Live previews
N/A