Dark mode: add badge in /dark-mode page#2387
Merged
julien-deramond merged 1 commit intomain-jd-dark-modefrom Nov 28, 2023
Merged
Dark mode: add badge in /dark-mode page#2387julien-deramond merged 1 commit intomain-jd-dark-modefrom
julien-deramond merged 1 commit intomain-jd-dark-modefrom
Conversation
julien-deramond
added
📖 documentation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
f254ccf to
a8f8146
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode-add-badge-in-dark-mode-page
branch
from
4d225da to
3cc3895
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
a8f8146 to
5f15275
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode-add-badge-in-dark-mode-page
branch
from
3cc3895 to
902254d
Compare
louismaximepiton
approved these changes
Nov 27, 2023
julien-deramond
deleted the
main-jd-dark-mode-add-badge-in-dark-mode-page
branch
julien-deramond
added a commit
that referenced
this pull request
Nov 29, 2023
julien-deramond
added a commit
that referenced
this pull request
Nov 30, 2023
julien-deramond
added a commit
that referenced
this pull request
Dec 1, 2023
julien-deramond
added a commit
that referenced
this pull request
Dec 4, 2023
julien-deramond
added a commit
that referenced
this pull request
Dec 8, 2023
julien-deramond
added a commit
that referenced
this pull request
Dec 15, 2023
julien-deramond
added a commit
that referenced
this pull request
Dec 18, 2023
julien-deramond
added a commit
that referenced
this pull request
Dec 21, 2023
julien-deramond
added a commit
that referenced
this pull request
Dec 26, 2023
julien-deramond
added a commit
that referenced
this pull request
Dec 27, 2023
julien-deramond
added a commit
that referenced
this pull request
Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the badge component in the /dark-mode page as a sub-task listed in #2223.
Note: Setting
data-bs-themedirectly onto the component when only defined as a<span>+.text-bg-{color}doesn't work at all times; the text color is not always the right color. This is due to the fact that, at the time of the creation of this PR, the color and background color are not automatically changed withdata-bs-theme.Live previews