Skip to content

Comments

[OUDS] text input review fixes#3211

Merged
vprothais merged 10 commits intoouds/mainfrom
ouds/main-sco-text-input-review-fix
Nov 13, 2025
Merged

[OUDS] text input review fixes#3211
vprothais merged 10 commits intoouds/mainfrom
ouds/main-sco-text-input-review-fix

Conversation

@nilloq
Copy link
Member

@nilloq nilloq commented Nov 7, 2025

Types of change

  • Non-breaking change

Context & Motivation

Fixes on Text Input following design and acccessibility review

Description

Checklists

  • I have read the contributing guidelines
  • My change follows the developer guide
  • My change pass all tests
  • My change is compatible with a responsive display
  • I have added tests (Javascript unit test or visual) to cover my changes
  • My change introduces changes to the documentation that I have updated accordingly
    • Title and DOM structure is correct
    • Links have been updated (title changes impact links)
    • CSS for the documentation
  • I have checked all states and combinations of the component with my change
  • I have checked all the impacts for the other components and core behavior (grid, reboot, utilities)

Checklist (for Core Team only)

  • The changes need to be in the migration guide
  • The changes are well displayed in Storybook (be careful if example order has changed for DSM)
  • The changes are compatible with RTL
  • Manually test browser compatibility with BrowserStack (Chrome 120, Firefox 121, Edge 120, Safari 15.6, iOS Safari, Chrome & Firefox on Android)

Progression (for Core Team only)

Live previews

@netlify
Copy link

netlify bot commented Nov 7, 2025

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit d64e721
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/6911f5d8f42d95000817adbe
😎 Deploy Preview https://deploy-preview-3211--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

</div> <div id="globalTextHelpBlock" class="text-input-helper">
Enter your email address without the domain name (e.g. only your username before the @).
<label for="inputTextWithPrefixSuffixIcon">Price</label>
<div class="input-container" data-bs-prefix="€"data-bs-suffix=".00">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could add a space before the data-bs-suffix attribute

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one could be a paragraph element too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@boosted-bot boosted-bot moved this from Need Dev Review to Dev Review In Progress in 🟣 [Orange-Boosted-Bootstrap] PRs Board Nov 7, 2025
@nilloq nilloq requested a review from vprothais November 10, 2025 08:16
@boosted-bot boosted-bot moved this from Dev Review In Progress to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Nov 13, 2025
@vprothais vprothais merged commit d5ea749 into ouds/main Nov 13, 2025
13 checks passed
@vprothais vprothais deleted the ouds/main-sco-text-input-review-fix branch November 13, 2025 15:46
@github-project-automation github-project-automation bot moved this from Need Lead Dev Review to Done in 🟣 [Orange-Boosted-Bootstrap] PRs Board Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants