[OUDS] fix(lib): Fix the inverse for the color-bgs

[louismaximepiton]

Types of change

• Non-breaking change
• Breaking change (fix or feature that would change existing functionality and usage)

Related issues

NA

Context & Motivation

Text-bg-inverse were broken.

Description

Use the right variable on inverse-high.
Use the right variable on inverse-low.

Checklists

• I have read the contributing guidelines
• My change follows the developer guide
• My change pass all tests
• My change is compatible with a responsive display
• I have added tests (Javascript unit test or visual) to cover my changes
• My change introduces changes to the documentation that I have updated accordingly
  • Title and DOM structure is correct
  • Links have been updated (title changes impact links)
  • CSS for the documentation
• I have checked all states and combinations of the component with my change
• I have checked all the impacts for the other components and core behavior (grid, reboot, utilities)

Checklist (for Core Team only)

• The changes need to be in the migration guide
• The changes are well displayed in Storybook (be careful if example order has changed for DSM)
• The changes are compatible with RTL
• Manually test browser compatibility with BrowserStack (Chrome 120, Firefox 121, Edge 120, Safari 15.6, iOS Safari, Chrome & Firefox on Android)

Progression (for Core Team only)

• Code review
• Design review
• A11y review
• Commit on ouds/main following conventional commit

Live previews

• https://deploy-preview-3218--boosted.netlify.app/orange/docs/helpers/color-background

[MaxLardenois]

LGTM

[vprothais]

We have a difference between both color on inverse low and high. The inverse content is #fff , but the default-content in dark is #eee. On the design side, those inverse bg colors are handled as local dark mode, so the text color should be content-default of dark mode (like we have when using bg-inverse-low helper for example).

After some exchanges with @louismaximepiton , we think these text-bg-* are not so useful anymore and could even be harmful, letting users think they switched to dark mode when it is just the text color that have been defined. A better solution might be to develop #3012, so the text color is well defined while using bg-* helpers and remove text-bg-* helpers.

[MaxLardenois]

After some exchanges with @louismaximepiton , we think these text-bg-* are not so useful anymore and could even be harmful, letting users think they switched to dark mode when it is just the text color that have been defined. A better solution might be to develop #3012, so the text color is well defined while using bg-* helpers and remove text-bg-* helpers.

Would seem logical to me that .bg-*** utilities set their content color, this would prevent error (also having .bg-** .text-bg and .text-** is difficult to understand). But this is a major API change, maybe we should hide/delete the color-background page in v1 if we plan to do that.

[louismaximepiton]

Closing it in favor of #3178.