Mise a jour date update search results en/fr#776
Open
Conversation
✅ Deploy Preview for a11y-guidelines ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Aniort
changed the title
qqs modifs FR
MewenLeHo
requested changes
Dec 10, 2025
Collaborator
There was a problem hiding this comment.
Good work. I just added some minor comments about some typos.
I will add that there are some HTML problems in the file (already present in the old version, not because of your update).
Main problem is that an ul must be outside a p not inside, it's forbidden by the spec.
I would recommend doing:
<p>Une fois la recherche lancée, en premier lieu, le titre de page ( <code>title</code>) doit être modifié pour mentionner :</p>
<ul>
<li>le fait que nous sommes sur une page de résultats de recherche</li>
<li>le terme recherché</li>
<li>le nombre total de résultats</li>
</ul>
instead of :
<p>Une fois la recherche lancée, en premier lieu, le titre de page ( <code>title</code>) doit être modifié pour mentionner : <br />
<ul>
<li>le fait que nous sommes sur une page de résultats de recherche</li>
<li>le terme recherché</li>
<li>le nombre total de résultats</li>
</ul>
</p>
And same for all ul in the file.
I am available if you have any question.
Co-authored-by: Mewen Le Hô <[email protected]>
✅ Deploy Preview for a11y-guidelines ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: Mewen Le Hô <[email protected]>
Co-authored-by: Mewen Le Hô <[email protected]>
Aniort
approved these changes
Feb 24, 2026
Collaborator
Aniort
left a comment
Aniort
left a comment
There was a problem hiding this comment.
some little things, typo, spelling
MewenLeHo
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.