Add collector mqtt exporter #417

tigroo · 2025-07-30T17:19:52Z

Changes

examples:
- collector: add a new mqtt exporter

Close #331

Test

How to test

Execute each example following the documentation into the README file.

nbuffon

The PR description should definitely tell what's to be tested related to the changes and not only redirect to the README

rust/src/transport/mqtt/routed_str_topic.rs

nbuffon · 2025-10-14T08:16:44Z

rust/src/transport/mqtt/routed_str_topic.rs

+            let string_topic = self.topic.to_string();
+            let parts = string_topic.split('/').collect::<Vec<&str>>();
+            let mut new_parts = parts.clone();
+            if level as usize <= parts.len() {


These might be included in StrTopic implementation

impl StrTopic { pub fn parts() -> &[&str] {...} pub fn len() { self.parts().len() } }

rust/src/transport/mqtt/routed_str_topic.rs

nbuffon · 2025-10-14T09:18:26Z

rust/src/transport/mqtt/routed_str_topic.rs

+        } else {
+            let string_topic = self.topic.to_string();
+            // Use the specified number of levels
+            let parts: Vec<&str> = string_topic.split('/').collect();


Same here, we could use an upper level len() and/or parts() method(s) on StrTopic

rust/examples/collector/main.rs

nbuffon · 2025-10-15T08:38:02Z

rust/examples/collector/collector_str_topic.rs

+            CollectorStrTopic::Level5(topic) => topic.as_route(),
+            CollectorStrTopic::Default(topic) => topic.as_route(),
+        }
+    }


This is a trait implementation, just put this code directly in the trait implementation

I don't understand : it's an enum implementation for me :(

as_route comes from Topic trait which is implemented for this enum later in this file by just calling this method.
What I mean is that you don't need this method as all its content belongs to the impl

impl Topic for CollectorStrTopic { fn as_route() { // here } }

@tigroo Last point remaining as explained yesterday do you want to push it now so I can approve this PR ?

rust/examples/config.ini

nbuffon · 2025-10-15T09:01:33Z

Just to mention, the collector example code need Rust 1.90 to work, it does not build under 1.85

error[E0658]: `let` expressions in this position are unstable
   --> examples/collector/main.rs:208:32
    |
208 | ...                   if let Some(file_exporter) = &exporter.file
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
   --> examples/collector/main.rs:209:36
    |
209 | ...                   && let Some(ref mut current_log_file) = log_file
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
   --> examples/collector/main.rs:225:36
    |
225 | ...                   && let Some(ref mut current_publish_client) = publish_client
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `libits-client` (example "collector") due to 3 previous errors

Simplifying to not build artificial sections just for call. Signed-off-by: Frédéric Gardes <[email protected]>

Signed-off-by: Frédéric Gardes <[email protected]>

tigroo · 2025-10-20T14:46:17Z

Just to mention, the collector example code need Rust 1.90 to work, it does not build under 1.85

error[E0658]: `let` expressions in this position are unstable
   --> examples/collector/main.rs:208:32
    |
208 | ...                   if let Some(file_exporter) = &exporter.file
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
   --> examples/collector/main.rs:209:36
    |
209 | ...                   && let Some(ref mut current_log_file) = log_file
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

error[E0658]: `let` expressions in this position are unstable
   --> examples/collector/main.rs:225:36
    |
225 | ...                   && let Some(ref mut current_publish_client) = publish_client
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `libits-client` (example "collector") due to 3 previous errors

#454

Signed-off-by: Frédéric Gardes <[email protected]>

Depending on a ROUTE_LEVEL, the topic can be routed differently (and not statically as the default str topic). Signed-off-by: Frédéric Gardes <[email protected]>

Add a getter to a list. Signed-off-by: Frédéric Gardes <[email protected]>

Fix minor comments. Create a collector str topic allowing 5 levels of routed str topic. Signed-off-by: Frédéric Gardes <[email protected]>

Signed-off-by: Frédéric Gardes <[email protected]>

tigroo · 2025-10-20T15:03:27Z

And in parallell, I try : #452

tigroo added this to the Sprint 13 milestone Jul 30, 2025

tigroo requested a review from nbuffon July 30, 2025 17:19

tigroo self-assigned this Jul 30, 2025

tigroo added the Rust Rust code label Jul 30, 2025

tigroo added this to its-client Jul 30, 2025

tigroo marked this pull request as draft July 30, 2025 17:20

tigroo moved this to In Progress in its-client Jul 30, 2025

tigroo force-pushed the add_collector_mqtt_exporter branch 5 times, most recently from dc33450 to 9709f0f Compare August 22, 2025 16:46

tigroo force-pushed the add_collector_mqtt_exporter branch 4 times, most recently from 73728f1 to ceb2ace Compare September 1, 2025 14:13

tigroo force-pushed the add_collector_mqtt_exporter branch from ceb2ace to a851f99 Compare September 30, 2025 09:20

tigroo marked this pull request as ready for review September 30, 2025 09:32

nbuffon reviewed Oct 15, 2025

View reviewed changes

tigroo added 2 commits October 20, 2025 11:17

rust: fix get functions naming

5a833ee

Simplifying to not build artificial sections just for call. Signed-off-by: Frédéric Gardes <[email protected]>

rust: allow to stringify a payload

9a7056f

Signed-off-by: Frédéric Gardes <[email protected]>

This was referenced Oct 20, 2025

put v1/traces as constant #453

Open

Fix Rust (1.90?) version #454

Open

tigroo added 5 commits October 20, 2025 17:02

rust: enhance comments

c29a378

Signed-off-by: Frédéric Gardes <[email protected]>

rust : provide a routed str topic

daa5df1

Depending on a ROUTE_LEVEL, the topic can be routed differently (and not statically as the default str topic). Signed-off-by: Frédéric Gardes <[email protected]>

rust: allow to consume from an example.

52d6726

Add a getter to a list. Signed-off-by: Frédéric Gardes <[email protected]>

rust: add mqtt exporter

156f07a

Fix minor comments. Create a collector str topic allowing 5 levels of routed str topic. Signed-off-by: Frédéric Gardes <[email protected]>

rust: use the British standard as the rest of code.

3df7326

Signed-off-by: Frédéric Gardes <[email protected]>

tigroo force-pushed the add_collector_mqtt_exporter branch from a851f99 to 3df7326 Compare October 20, 2025 15:02

tigroo requested a review from nbuffon October 20, 2025 15:38

nbuffon modified the milestones: Sprint 13, Sprint 15 Nov 4, 2025

Add collector mqtt exporter #417

Are you sure you want to change the base?

Add collector mqtt exporter #417

Uh oh!

Conversation

tigroo commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Test

How to test

Uh oh!

nbuffon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nbuffon Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nbuffon Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nbuffon Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

tigroo Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

nbuffon Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

nbuffon Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nbuffon commented Oct 15, 2025

Uh oh!

tigroo commented Oct 20, 2025

Uh oh!

tigroo commented Oct 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tigroo commented Jul 30, 2025 •

edited

Loading