Skip to content

Conversation

@louismaximepiton
Copy link
Member

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Supersedes #79.
Closes #16.
Might resolve or help on #12.

Description

Adding terser as a plugin.

Motivation & Context

Minify the bundle. For now, it goes from 260KB to 45KB.
Several questions came to my mind while doing this:

  • Should we provide the two files (ods-charts.js and ods-charts.min.js) ?
  • Should we use .min file on the examples or not ?
  • Should we use a banner.js/txt file in order to not repeat ourselves on the banner text and ease the maintenance as well ?
  • Should we keep the source map or not ? if we should keep it, we might remove: devtool: false.

Types of change

  • New feature (non-breaking change which adds functionality)

Test checklist

Please check that the following tests projects are still working:

  • docs/examples
  • test/angular-ngx-echarts
  • test/angular-tour-of-heroes
  • test/html
  • test/react
  • test/vue
  • test/examples/bar-line-chart
  • test/examples/single-line-chart
  • test/examples/timeseries-chart

@netlify
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit f6bbf4e
🔍 Latest deploy log https://app.netlify.com/projects/ods-charts/deploys/688373e89243c20008589e1b
😎 Deploy Preview https://deploy-preview-311--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jacques-lebourgeois jacques-lebourgeois force-pushed the main-lmp-minified-version branch from 1c7cd95 to f6bbf4e Compare July 25, 2025 12:09
@jacques-lebourgeois
Copy link
Member

jacques-lebourgeois commented Jul 25, 2025

@louismaximepiton , I rebase your PR. Maybe it will be time to merge it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minified version of the library

2 participants