-
Notifications
You must be signed in to change notification settings - Fork 2
feat: create component - navigation bar #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paulinea
wants to merge
26
commits into
develop
Choose a base branch
from
410-create-component---bottom-navigation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
0999986
Add navigation bar tokens
paulinea d4b507d
Add OUDS navigation bar component
paulinea 2ca4df5
Add navigation bar component in demo app
paulinea 267df2d
Add snapshots
paulinea 42d2af8
Replace preview state by preview enum entry
paulinea 6e812bd
Allow badges on navigation bar items
paulinea f736c32
Fix after rebase
paulinea c0088f9
Fix after rebase
paulinea aa6c375
Update navigation bar component to the last version with new tokens
paulinea 21b020b
Implement blurred navigation bar with Haze library
paulinea 6effe2b
Add navigation bar screenshots
paulinea 48d6ffb
Update navigation bar illustration
paulinea fdb0976
Add badge customization in navigation bar
paulinea d8ceaf7
Support navigation bar badge accessibility
paulinea 6ea19a7
Add navigation bar tests
paulinea d901a4e
Document how to implement a translucent blurred navigation bar
paulinea 7529439
Remove useless tokens
paulinea 60c00e9
Add missing tokens
paulinea 4910129
Add translucent parameter to OudsNavigationBar
paulinea f4bfff3
Add border around navigation bar badge
paulinea ec63310
Update navigation bar snapshots
paulinea 6cd3a57
Update navigation bar illustration by adding horizontal padding
paulinea b449f85
Display the opaque version of the bar before Android 13
paulinea c9385c1
Fix after rebase
paulinea ee21996
Remove disabled state for OudsNavigationBarItem
paulinea 62e1a0b
Update snapshots
paulinea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,9 @@ package com.orange.ouds.app.ui.components | |
|
|
||
| import androidx.compose.foundation.layout.Arrangement | ||
| import androidx.compose.foundation.layout.Column | ||
| import androidx.compose.foundation.layout.Spacer | ||
| import androidx.compose.foundation.layout.fillMaxSize | ||
| import androidx.compose.foundation.layout.height | ||
| import androidx.compose.foundation.layout.padding | ||
| import androidx.compose.foundation.rememberScrollState | ||
| import androidx.compose.foundation.verticalScroll | ||
|
|
@@ -24,6 +26,7 @@ import androidx.compose.ui.res.stringResource | |
| import androidx.compose.ui.tooling.preview.PreviewLightDark | ||
| import com.orange.ouds.app.ui.utilities.composable.LargeCard | ||
| import com.orange.ouds.app.ui.utilities.composable.Screen | ||
| import com.orange.ouds.core.component.OudsNavigationBarHeight | ||
| import com.orange.ouds.core.theme.OudsTheme | ||
| import com.orange.ouds.core.utilities.OudsPreview | ||
|
|
||
|
|
@@ -52,6 +55,7 @@ private fun ComponentsScreen(components: List<Component>, onComponentClick: (Lon | |
| onClick = { onComponentClick(component.id) } | ||
| ) | ||
| } | ||
| Spacer(modifier = Modifier.height(OudsNavigationBarHeight)) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if there is a more conventional way of doing this with the window insets. I did not take time to look at this but I can investigate that point (I need to read the documentation again because I forgot everything about window insets 😅). |
||
| } | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A detail,
ic_shop_storeshould be placed beforeic_sms_message.