Skip to content

[#971] Hide divider by default in radio item checkbox item switch item #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 4, 2025
Merged

[#971] Hide divider by default in radio item checkbox item switch item #118

merged 4 commits into from
Nov 4, 2025

Conversation

@ludovic35
Copy link
Member

@ludovic35 ludovic35 commented Nov 4, 2025 •
edited by pylapp
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Orange-OpenSource/ouds-ios#971

Description

Motivation & Context

Types of change

  • Refactoring (non-breaking change)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I checked I am using the last version of OUDS iOS library
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • NA Design review has been done
  • NA Accessibility review has been done
  • NA Q/A team has tested the evolution
  • NA Documentation has been updated if relevant
  • NA Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

@ludovic35 ludovic35 requested a review from pylapp as a code owner November 4, 2025 10:49
@ludovic35 ludovic35 force-pushed the 971-component-update-control-item-based-components-must-have-hidden-divider-by-default branch from f3bd8a6 to eddb806 Compare November 4, 2025 10:51
@pylapp pylapp self-assigned this Nov 4, 2025
@pylapp pylapp force-pushed the 971-component-update-control-item-based-components-must-have-hidden-divider-by-default branch from b787447 to cc64377 Compare November 4, 2025 13:52
@pylapp pylapp merged commit 4648bf5 into develop Nov 4, 2025
8 of 16 checks passed
@pylapp pylapp deleted the 971-component-update-control-item-based-components-must-have-hidden-divider-by-default branch November 4, 2025 13:53
pylapp pushed a commit that referenced this pull request Nov 4, 2025
@ludovic35 @pylapp
refactor: hide divider by default in radio item, checkbox item an…
ea8d60e 
…d `switch item` (Orange-OpenSource/ouds-ios#971) (#118)

Closes Orange-OpenSource/oud-ios#971

Reviewed-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pylapp pylapp Awaiting requested review from pylapp pylapp is a code owner

Assignees

@pylapp pylapp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ludovic35 @pylapp