Skip to content

[#1117] Use Swift package umbrella product #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 4, 2025
Merged

[#1117] Use Swift package umbrella product #119

merged 5 commits into from
Nov 4, 2025

Conversation

@pylapp
Copy link
Member

@pylapp pylapp commented Nov 4, 2025 •
edited
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Orange-OpenSource/ouds-ios#1117

Description

Update design ssytem toolbox to embed only the umbrella product and use it

Motivation & Context

Types of change

  • Refactoring (non-breaking change)

Previews

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices

Design

  • (NA) My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I checked I am using the last version of OUDS iOS library
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibility review has been done
  • (NA) Q/A team has tested the evolution
  • (NA) Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

@pylapp pylapp requested a review from ludovic35 as a code owner November 4, 2025 13:42
@pylapp pylapp changed the title [#1117] use Swift package umbrella product [#1117] Use Swift package umbrella product Nov 4, 2025
@pylapp pylapp mentioned this pull request Nov 4, 2025
Merged
11 tasks
@pylapp
Copy link
Member Author

pylapp commented Nov 4, 2025 •
edited
Loading

@ludovic35 Example de message de commit :

refactor: use umbrella Swift package `OUDSSwiftUI` product  (Orange-OpenSource/ouds-ios#1117) (#119)

Note

Merge cette PR après avoir mergé celle du Swift Package (Orange-OpenSource/ouds-ios#1122)

@pylapp
chore: clean up
1ac4568 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp merged commit 9f84ae1 into develop Nov 4, 2025
8 of 16 checks passed
@pylapp pylapp deleted the 1117-reduce-number-of-imports branch November 4, 2025 16:15
pylapp added a commit that referenced this pull request Nov 4, 2025
@pylapp
refactor: use umbrella Swift package OUDSSwiftUI product (Orange-Op…
25f875c 
…enSource/ouds-ios#1117) (#119)

Related to Orange-OpenSource/ouds-ios#1117

Suggested-by: Thomas Martin <[email protected]>
Reviewed-by: Ludovic Pinel <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ludovic35 ludovic35 Awaiting requested review from ludovic35 ludovic35 is a code owner

Assignees

@ludovic35 ludovic35

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pylapp @ludovic35