Skip to content

[#1041] Add flip option for icon on the trailing action of the text input #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 12, 2025
Merged

[#1041] Add flip option for icon on the trailing action of the text input #125

merged 4 commits into from
Nov 12, 2025

Conversation

@ludovic35
Copy link
Member

@ludovic35 ludovic35 commented Nov 7, 2025

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Orange-OpenSource/ouds-ios#1041

Description

Motivation & Context

Types of change

  • New feature (non-breaking change which adds functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibility review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@ludovic35 ludovic35 requested a review from pylapp as a code owner November 7, 2025 13:34
@pylapp pylapp force-pushed the develop branch 2 times, most recently from c30b793 to 7e56edd Compare November 11, 2025 23:33
@pylapp pylapp self-assigned this Nov 12, 2025
@pylapp pylapp force-pushed the 1041-bug-trailing-icon-flip-in-the-input-text branch from 728446f to 30e1c83 Compare November 12, 2025 09:42
pylapp
pylapp approved these changes Nov 12, 2025
View reviewed changes
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with my fixes

@pylapp pylapp merged commit d8b82fb into develop Nov 12, 2025
11 of 16 checks passed
@pylapp pylapp deleted the 1041-bug-trailing-icon-flip-in-the-input-text branch November 12, 2025 09:44
pylapp added a commit that referenced this pull request Nov 12, 2025
@ludovic35 @pylapp
feat: add flip icon option for text input component trailing action (…
230c56d 
…Orange-OpenSource/ouds-ios#1041) (#125)

Related to Orange-OpenSource/ouds-ios#1041

Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Ludovic Pinel <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pylapp pylapp pylapp approved these changes

Assignees

@pylapp pylapp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ludovic35 @pylapp