Skip to content

[#665] Integration of Sosh theme #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 10, 2025
Merged

[#665] Integration of Sosh theme #822

merged 16 commits into from
Jul 10, 2025

Conversation

pylapp
Copy link
Member

@pylapp pylapp commented Jul 7, 2025 •
edited
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#665

Description

Implementation of Sosh theme

Motivation & Context

Expose new theme for v1

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices

Design

  • (NA) My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • Design review has been done
  • Accessibility review has been done
  • Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@pylapp pylapp requested a review from ludovic35 as a code owner July 7, 2025 11:54
@pylapp pylapp linked an issue Jul 7, 2025 that may be closed by this pull request
[Theme] Integration of Sosh theme #665
Closed
14 tasks
@pylapp pylapp marked this pull request as draft July 7, 2025 11:54
@pylapp pylapp force-pushed the 665-theme-integration-of-sosh-theme branch from 7018886 to ac4206a Compare July 7, 2025 11:55
@pylapp
Copy link
Member Author

pylapp commented Jul 7, 2025 •
edited
Loading

Caution

To be merged before the following one: Orange-OpenSource/ouds-ios-design-system-toolbox#30

@pylapp pylapp mentioned this pull request Jul 7, 2025
Merged
13 tasks
@pylapp pylapp changed the title [#665] Theme integration of Sosh theme [#665] Integration of Sosh theme Jul 8, 2025
pylapp and others added 12 commits July 9, 2025 11:53
@pylapp
feat: add base elements and providers for Sosh theme (#665)
e39da5e 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@boosted-bot @pylapp
chore(🤖): add raw tokens for Sosh (#665) (#809)
c77cf7d 
Add brand core raw tokens of colors and fonts
Make some fake values to allow builds

Related to #665

Co-authored-by: boosted-bot <[email protected]>
Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@boosted-bot @pylapp
chore(🤖): add Sosh border semantic tokens (#665) (#810)
dc5b8dd 
Updates styles and linter commands, add more tests and border semantic tokens for Sosh theme

Co-authored-by: boosted-bot <[email protected]>
Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@boosted-bot @pylapp
chore(🤖): update of color semantic tokens for Sosh theme (#665) (#811)
65ea85f 
Update styles, docs, tests

Co-authored-by: boosted-bot <[email protected]>
Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@boosted-bot @pylapp
chore(🤖): update of semantic tokens of elevaiton, grid, space and siz…
1438dfd 
…e for theme `Sosh` (#665) (#812)

Co-authored-by: boosted-bot <[email protected]>
@boosted-bot @pylapp
chore(🤖): update of semantic tokens ofr dimension, font and opacity f…
bf9a64f 
…or `Sosh` theme (#665) (#813)

Co-authored-by: boosted-bot <[email protected]>
@boosted-bot @pylapp
chore(🤖): update of tokens for clor mode semantic tokens of Sosh th…
9fcafb1 
…eme (#665) (#815)

Co-authored-by: boosted-bot <[email protected]>
@boosted-bot @pylapp
chore(🤖): update all components tokens for Sosh theme (#665) (#816)
4c73fb3 
Co-authored-by: boosted-bot <[email protected]>
@pylapp
test: update unit tests for Sosh objects (#665)
7953fbf 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
feat: add assets for Soh theme and update Orange theme assets (#665)
c70b7c6 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: docs and use of fonts (#665)
ad7da07 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
feat: docs, fonts, theme, NOTICE (#665)
69e1cd3 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp force-pushed the 665-theme-integration-of-sosh-theme branch from ce43ffa to 69e1cd3 Compare July 9, 2025 09:53
boosted-bot and others added 4 commits July 9, 2025 14:29
@boosted-bot @pylapp
chore(🤖): update tokens with forbidden color values (#835)
74e016d 
Related to #665

Co-authored-by: boosted-bot <[email protected]>
Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: update tokens
1f017a9 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor: managemnt of surface colors and color modes for themes
725b2aa 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: update changelog
005780e 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp marked this pull request as ready for review July 10, 2025 12:10
@pylapp pylapp merged commit d895a71 into develop Jul 10, 2025
10 of 14 checks passed
@pylapp pylapp deleted the 665-theme-integration-of-sosh-theme branch July 10, 2025 12:12
pylapp added a commit that referenced this pull request Jul 10, 2025
@pylapp @boosted-bot
feat: add Sosh theme (#665) (#822)
0061350 
- Add Sosh theme
- Update color semantic tokens and color mode semantic tokens

Closes #665

Reviewed-by: Ludovic Pinel <[email protected]>
Co-authored-by: OUDS Bot [bot] <[email protected]>
Co-authored-by: boosted-bot <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludovic35 ludovic35 Awaiting requested review from ludovic35 ludovic35 is a code owner

Assignees

@ludovic35 ludovic35

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Theme] Integration of Sosh theme
3 participants
@pylapp @ludovic35 @boosted-bot