[#956] Remove button trait for filter chip and add toggle trait if iOS 17+
#966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S 17+ (#956) Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
1 task
ludovic35
requested changes
Sep 17, 2025
| /// Thus an hint is automatically added and a custom hint is not needed anymore/ | ||
| private var accessibilityHint: String { | ||
| (selected ? "core_filterchip_hint_selected_a11y" : "core_filterchip_hint_unselected_a11y").localized() | ||
| if #available(iOS 17.0, *) { |
Member
There was a problem hiding this comment.
Est-ce que l'on ne pouvais pas faire ceci dans le modifier ?
et avec le clef de wording core_common_selected_a11y ?
Et utiliser pour le radio et peut -êttre le picker ?
pylapp
force-pushed
the
develop
branch
2 times, most recently
from
359407c to
6fa9080
Compare
pylapp
force-pushed
the
develop
branch
2 times, most recently
from
ad3ed96 to
2f1e2c0
Compare
pylapp
force-pushed
the
develop
branch
4 times, most recently
from
61fb35f to
56b76ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableCaution
Need review and acknowledgment of @pya35 before merge!
Related issues
#956
Description
Apply suitable traits for filter chip component
Motivation & Context
Types of change
Previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)