Skip to content

Update YesSql packages to 5.4.1 #18039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2025
Merged

Update YesSql packages to 5.4.1 #18039

merged 3 commits into from
Jun 19, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 15, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
YesSql 5.3.0 -> 5.4.1 age adoption passing confidence
YesSql.Abstractions 5.3.0 -> 5.4.1 age adoption passing confidence
YesSql.Core 5.3.0 -> 5.4.1 age adoption passing confidence
YesSql.Filters.Abstractions 5.3.0 -> 5.4.1 age adoption passing confidence
YesSql.Filters.Query 5.3.0 -> 5.4.1 age adoption passing confidence

Release Notes

sebastienros/yessql (YesSql)

v5.4.1: 5.4.1

What's Changed

Full Changelog: sebastienros/yessql@v5.4.0...v5.4.1

v5.4.0: 5.4.0

What's Changed

Full Changelog: sebastienros/yessql@v5.3.0...v5.4.0


Configuration

📅 Schedule: Branch creation - Between 12:00 AM and 06:59 AM, only on Sunday ( * 0-6 * * 7 ) (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jun 15, 2025
@MikeAlhayek
Copy link
Member

There are failing because YesSql added

Many of these analyzers are good to adapt.

@Piedone
Copy link
Member

Piedone commented Jun 15, 2025

YesSql added Meziantou.Analyzer, you mean? That's a good analyzer package, but we shouldn't just use it from YesSql transitively. That reference needs to be changed with <ExcludeAssets>analyzers</ExcludeAssets> so we don't include any analyzers that YesSql does automatically, but reference it directly. I see you're working on this under ma/add-Meziantou.Analyzer, so please change this too.

@sebastienros
Copy link
Member

sebastienros/yessql#634

@renovate renovate bot force-pushed the renovate/yessql-packages branch from bd7c000 to 768294c Compare June 16, 2025 23:25
@renovate renovate bot changed the title Update YesSql packages to 5.4.0 Update YesSql packages to 5.4.1 Jun 16, 2025
@Piedone
Copy link
Member

Piedone commented Jun 16, 2025

The build fails due to an analyzer violation to use the cancellation token feature introduced under sebastienros/yessql#627. The violations are valid, but much like async, this propagates through the whole call chain and would require us to basically change everything that touches the DB (and ultimately, the token should come from HttpContext.RequestAborted except for background task).

How should we handle this in the most sensible way, @sebastienros?

@sebastienros
Copy link
Member

We can update the calls in this PR, and use default when we don't have any meaningful token to use.

@Piedone
Copy link
Member

Piedone commented Jun 17, 2025

How about having an ICancellationTokenAccess, in a similar vein to IUpdateModelAccessor? Then, we could use HttpContext.RequestAborted for that by default, except in background tasks where we have another token.

Copy link
Contributor Author

renovate bot commented Jun 18, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@sebastienros sebastienros requested a review from Piedone June 19, 2025 18:19
@Piedone Piedone merged commit 7783107 into main Jun 19, 2025
17 checks passed
@Piedone Piedone deleted the renovate/yessql-packages branch June 19, 2025 20:38
@MikeAlhayek
Copy link
Member

/backport to release/2.2

Guessing this will fail but trying my luck

Copy link
Contributor

Started backporting to release/2.2: https://github.com/OrchardCMS/OrchardCore/actions/runs/15796062050

Copy link
Contributor

@MikeAlhayek backporting to "release/2.2" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Update YesSql packages to 5.4.1
Using index info to reconstruct a base tree...
M	Directory.Packages.props
Falling back to patching base and 3-way merge...
Auto-merging Directory.Packages.props
CONFLICT (content): Merge conflict in Directory.Packages.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Update YesSql packages to 5.4.1
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants