Wip windows #1

Osyotr · 2024-04-09T22:39:58Z

No description provided.

vaanwd · 2024-11-17T17:16:36Z

Hello!
Do you have some instrunctions of how to build Organic Maps on Windows?
Thank`s!

Osyotr · 2024-11-17T19:43:34Z

The build steps are there: https://github.com/Osyotr/organicmaps/blob/wip-windows/.github/workflows/windows-check.yaml
The important step is to skip some submodules.

PS: windows builds are not usable at this moment due to organicmaps#7838

vaanwd · 2024-11-19T09:17:40Z

The build steps are there: https://github.com/Osyotr/organicmaps/blob/wip-windows/.github/workflows/windows-check.yaml The important step is to skip some submodules.

PS: windows builds are not usable at this moment due to organicmaps#7838

Yes, i have the same problem(Black screen) in Arch Linux with QT 6.8.
There is a posibility to downgrade QT in vcpkg?

Osyotr · 2024-11-19T09:53:34Z

Yes but I think the OpenGL issue is deeper because with Qt 6.6 it will crash 9/10 times.
https://learn.microsoft.com/en-us/vcpkg/consume/lock-package-versions?tabs=inspect-powershell#5---force-a-specific-version

…ange Signed-off-by: Kiryl Kaveryn <[email protected]>

Signed-off-by: Alexander Borsuk <[email protected]>

Signed-off-by: kavikhalique <[email protected]>

Signed-off-by: Kiryl Kaveryn <[email protected]>

Signed-off-by: Viktor Govako <[email protected]>

Signed-off-by: Kiryl Kaveryn <[email protected]>

The bug is quite rare and happens when the user taps on the edit (pencil) button on the PlacePage. It seems like the tap happens during the PP data object reloading the and the object type has changed. It is better to avoid failing in such cases because we cannot prevent user interaction during the pp reloading. Signed-off-by: Kiryl Kaveryn <[email protected]>

> При уходе с тропы если язык подсказок русский, говорит - «преращик маршрута». Signed-off-by: Alexander Borsuk <[email protected]>

Signed-off-by: Osyotr <[email protected]>

Windows is performing path normalization anyways. Fixes some unit tests that expect the output to contain forward slashes. Signed-off-by: Osyotr <[email protected]>

Signed-off-by: Osyotr <[email protected]>

It's going to be maximized anyway.

github-actions · 2025-08-06T20:02:05Z

libs/base/string_utils.cpp

@@ -227,15 +227,15 @@ void AsciiToUpper(std::string & s)

 void Trim(std::string & s)
 {
-  boost::trim_if(s, ::isspace);
+  boost::trim_if(s, [](unsigned char c){ return std::isspace(c); });


[clang-format] _{reported by reviewdog 🐶}

Suggested change

boost::trim_if(s, [](unsigned char c){ return std::isspace(c); });

boost::trim_if(s, [](unsigned char c) { return std::isspace(c); });

github-actions · 2025-08-06T20:02:05Z

libs/base/timegm.cpp

+    std::tm tmp = tm;
+    return _mkgmtime(&tmp);


[clang-format] _{reported by reviewdog 🐶}

Suggested change

std::tm tmp = tm;

return _mkgmtime(&tmp);

std::tm tmp = tm;

return _mkgmtime(&tmp);

github-actions · 2025-08-06T20:02:05Z

libs/base/timegm.cpp

+    std::tm tmp = tm;
+    return _mkgmtime(&tmp);
+#else
+    return timegm(&tm);


[clang-format] _{reported by reviewdog 🐶}

Suggested change

return timegm(&tm);

return timegm(&tm);

github-actions · 2025-08-06T20:02:05Z

libs/indexer/search_string_utils.cpp

@@ -54,7 +54,7 @@ void TransliterateHiraganaToKatakana(UniString & s)

 size_t GetMaxErrorsForToken(UniString const & token)
 {
-  bool const digitsOnly = std::all_of(token.begin(), token.end(), ::isdigit);
+  bool const digitsOnly = std::all_of(token.begin(), token.end(), [](unsigned char c){ return std::isdigit(c); });


[clang-format] _{reported by reviewdog 🐶}

Suggested change

bool const digitsOnly = std::all_of(token.begin(), token.end(), [](unsigned char c){ return std::isdigit(c); });

bool const digitsOnly = std::all_of(token.begin(), token.end(), [](unsigned char c) { return std::isdigit(c); });

github-actions · 2025-08-06T20:02:05Z

libs/platform/location_service/location_service.cpp

@@ -75,6 +75,9 @@ class DesktopLocationService
 #if defined(OMIM_OS_LINUX)
    m_services.push_back(CreateQtLocationService(*this, "geoclue2"));
 #endif                                 // OMIM_OS_LINUX


[clang-format] _{reported by reviewdog 🐶}

Suggested change

#endif // OMIM_OS_LINUX

#endif // OMIM_OS_LINUX

github-actions · 2025-08-06T20:02:06Z

libs/routing/routing_quality/api/google/google_api.cpp

@@ -29,7 +29,7 @@ auto GetNextDayAtNight(int32_t startTimeZoneUTC)
  std::tm * nextDayDate = std::localtime(&nextDay);

  long constexpr kSecondsInHour = 3600;
-  int const curUTCOffset = static_cast<int>(nextDayDate->tm_gmtoff / kSecondsInHour);
+  int const curUTCOffset = static_cast<int>(0 / kSecondsInHour); // TODO


[clang-format] _{reported by reviewdog 🐶}

Suggested change

int const curUTCOffset = static_cast<int>(0 / kSecondsInHour); // TODO

int const curUTCOffset = static_cast<int>(0 / kSecondsInHour); // TODO

github-actions · 2025-08-06T20:02:06Z

libs/search/search_integration_tests/generate_tests.cpp

-  };
-  dataSource.ForEachInScale(fn, scales::GetUpperScale());
+    int count = 0;
+    auto const fn = [&](FeatureType & ft) {


[clang-format] _{reported by reviewdog 🐶}

Suggested change

auto const fn = [&](FeatureType & ft) {

auto const fn = [&](FeatureType & ft)

{

github-actions · 2025-08-06T20:02:06Z

libs/testing/testingmain.cpp

@@ -25,6 +25,10 @@
 #include <CoreFoundation/CoreFoundation.h>
 #endif

+#ifdef OMIM_OS_WINDOWS
+# include <windows.h>


[clang-format] _{reported by reviewdog 🐶}

Suggested change

# include <windows.h>

#include <windows.h>

github-actions · 2025-08-06T20:02:06Z

qt/main.cpp

@@ -239,7 +239,7 @@ int main(int argc, char * argv[])
 #endif  // BUILD_DESIGNER

    Framework framework(frameworkParams);
-    qt::MainWindow w(framework, std::move(screenshotParams), QApplication::primaryScreen()->geometry()
+    qt::MainWindow w(framework, std::move(screenshotParams)
 #ifdef BUILD_DESIGNER
                                                                 ,


[clang-format] _{reported by reviewdog 🐶}

Suggested change

,

,

github-actions · 2025-08-06T20:03:33Z