WIP Windows lite #2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Osyotr
force-pushed
the
windows-lite
branch
2 times, most recently
from
36f706e to
cfd5285
Compare
Osyotr
force-pushed
the
windows-lite
branch
3 times, most recently
from
9c404c1 to
7d71c77
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
libs/base/string_utils.hpp
Outdated
|
|
||
| template <typename T, typename = std::enable_if_t<std::is_signed<T>::value && sizeof(T) == sizeof(long long)>> | ||
| long long IntConverter(char const * start, char ** stop, int base) | ||
| template<std::integral T> |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| template<std::integral T> | |
| template <std::integral T> |
libs/base/string_utils.hpp
Outdated
| template <typename T, | ||
| typename = std::enable_if_t<std::is_unsigned<T>::value && sizeof(T) == sizeof(unsigned long long)>> | ||
| unsigned long long IntConverter(char const * start, char ** stop, int base) | ||
| template<std::floating_point T> |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| template<std::floating_point T> | |
| template <std::floating_point T> |
libs/base/string_utils.hpp
Outdated
| } | ||
|
|
||
| result = static_cast<T>(v); | ||
| return true; | ||
| } |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| } | |
| } // namespace impl |
libs/base/string_utils.hpp
Outdated
|
|
||
| [[nodiscard]] inline bool to_int(char const * s, int & i, int base = 10) | ||
| template<std::signed_integral T> |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| template<std::signed_integral T> | |
| template <std::signed_integral T> |
libs/base/string_utils.hpp
Outdated
| } | ||
|
|
||
| [[nodiscard]] inline bool to_uint(char const * s, unsigned int & i, int base = 10) | ||
| template<std::unsigned_integral T> |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| template<std::unsigned_integral T> | |
| template <std::unsigned_integral T> |
| @@ -177,8 +172,10 @@ int main(int argc, char * argv[]) | |||
| { | |||
| std::unique_ptr<qt::ScreenshotParams> screenshotParams; | |||
|
|
|||
| #ifndef _WIN32 | |||
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| #ifndef _WIN32 | |
| #ifndef _WIN32 |
| if (!FLAGS_lang.empty()) | ||
| (void)::setenv("LANGUAGE", FLAGS_lang.c_str(), 1); | ||
| #endif |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| #endif | |
| #endif |
Osyotr
force-pushed
the
windows-lite
branch
8 times, most recently
from
db1e745 to
1cab00a
Compare
Osyotr
force-pushed
the
windows-lite
branch
2 times, most recently
from
c98b520 to
8e5fdc6
Compare
Signed-off-by: Alexander Borsuk <[email protected]>
Signed-off-by: Alexander Borsuk <[email protected]>
Signed-off-by: Alexander Borsuk <[email protected]>
…h-HK and zh-MO Signed-off-by: Alexander Borsuk <[email protected]>
Signed-off-by: Alexander Borsuk <[email protected]>
Drive-by: fix log spam from usiage of glLineWidth with values greater than 1 in core context. Signed-off-by: Osyotr <[email protected]>
Signed-off-by: Viktor Govako <[email protected]>
Signed-off-by: Andrei Shkrob <[email protected]>
Signed-off-by: Osyotr <[email protected]>
Signed-off-by: Osyotr <[email protected]>
Signed-off-by: Osyotr <[email protected]>
Signed-off-by: Osyotr <[email protected]>
Signed-off-by: Osyotr <[email protected]>
Signed-off-by: Osyotr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.