Add unused docker/dagger-based testing workflow, adopt PEP 517/621/639, documentation cleanup

[Zeitsperre]

Changes

• Stages a docker-based testing workflow (using Dagger) for running integration testing workflows both locally and on CI systems
• Adds a linting workflow using pre-commit
• Adds a YAML linting step and a documentation code style checking step to the pre-commit configuration.
• Updates the name of sphinx-rtd-theme (previously sphinx_rtd_theme)
• Updates the build system to use PEP 517/621/639 using flit
• Cleans up several broken/redirected links in the documentation

[tlvu]

Great stuff. I am not too familiar with Dagger and Github actions in general but I just don't see where the same pytest as our Jenkins is being run.

Also same questions as all other pipelines you've been adding lately: can we trigger this manually without having to push new commits?

[tlvu]

Wow =========== 53 failed, 89 passed, 15 warnings in 17512.32s (4:51:52) ===========
@Zeitsperre All the html and embeded javascript diff error because I forgot to tell you how to ignore them in output change, sorry !: https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests/blob/d2c89f6ef72e189fbba90e7370d6c1aacdd7bbdf/conftest.py#L1-L6

Added the override in and directed pytest to use it, but it doesn't seem to do anything? Am I missing something here?

@Zeitsperre
Nothing special to add.

However I noticed your conftest.py file is located at /code/tests while all your notebooks are under /code/docs/. Not sure, but maybe they should be under the same tree? Or maybe your starting working dir should be were the conftest.py file is located?

[tlvu]

@Zeitsperre See comment #300 (comment)

Nothing is missing in the Jupyter docker image. As I said in comment #300 (comment) earlier, the default Jupyter image should not be latest because that one is rebuilt randomly and never tested. Please use the current tested production version 230601.

[tlvu]

@Zeitsperre Going through my old PRs to review list, is this one still relevant?

[Zeitsperre]

It's still useful, but the issues I've run into when running this toolset is that there are few computers with enough RAM to run the stack as it is. Resources on GitHub CI are not plentiful enough to run it, nor is my local workstation. Great case for Jenkins though...

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[Zeitsperre]

@tlvu This Pull Request has been significantly changed:

• The dagger-based workflow is too heavy to run on GitHub Workflows, so I've disabled it, and we can try working with it once we get access to more Jenkins CI resources
• The documentation has been significantly cleaned up
  • There is one last broken URL to deal with (https://www.ouranos.ca/wp-content/uploads/FrigonKoenig_2021_FloodFreqAnalDamSafetyCC_EN.pdf). I've asked colleagues if they know the report and if the new URL is available. Will update when I hear back

There is plenty of valuable change in this contribution, and it doesn't significantly impact the repo, so we can probably go forward with it once you give the OK. Thanks again

[tlvu]

LGTM. All my comments are not blocking. You can merge as-is if you wish to. But next time maybe you should not mix fixing the documentation content together with fixing the code infrastructure.

I see some very useful and minor documentations updates (ex: use https instead of http for link, link updates, ...) that could have gone out much earlier if you had not lump them into this PR but have them in a separate PR.