Skip to content

Conversation

@tlogan2000
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlogan2000 tlogan2000 merged commit 54078cc into master Jan 23, 2026
3 checks passed
@tlogan2000 tlogan2000 deleted the update_CaSR_version branch January 23, 2026 18:08
tlvu added a commit that referenced this pull request Jan 23, 2026
Diff coming from #371

```
  _______ pavics-sdi-master/docs/source/notebooks/CaSR_basic.ipynb::Cell 0 _______
  Notebook cell execution failed
  Cell 0: Cell outputs differ

  Input:
  import xarray as xr

  url = "https://pavics.ouranos.ca/twitcher/ows/proxy/thredds/dodsC/datasets/reanalyses/day_NAM_GovCan_CaSR_v32_1980-2024.ncml"

  # Open dataset. For hourly data, we suggest using the following chunking pattern: dict(time=1461, rlon=50, rlat=50)  : 4 year chunks in time dim
  ds = xr.open_dataset(url, chunks=dict(time=1461, rlon=50, rlat=50))
  ds

  Traceback:
   mismatch 'text/plain'

   assert reference_output == test_output failed:

    '<xarray.Data...     CaSRv3.2' == '<xarray.Data...     CaSRv3.2'

    - <xarray.Dataset> Size: 2TB
    ?                        ^
    + <xarray.Dataset> Size: 1TB
    ?                        ^
      Dimensions:       (rlat: 778, rlon: 706, time: 16437)
      Coordinates:
        * rlat          (rlat) float32 3kB -44.1 -44.01 -43.92 ... 25.65 25.74 25.83
        * rlon          (rlon) float32 3kB -35.4 -35.31 -35.22 ... 27.87 27.96 28.05
          rotated_pole  int32 4B ...
        * time          (time) datetime64[ns] 131kB/DATE/... 2024-12-31
          lat           (rlat, rlon) float32 2MB dask.array<chunksize=(50, 50), meta=np.ndarray>
          lon           (rlat, rlon) float32 2MB dask.array<chunksize=(50, 50), meta=np.ndarray>
    - Data variables: (12/49)
    ?                      ^
    + Data variables: (12/41)
    ?                      ^
    -     orog          (rlat, rlon) float32 2MB dask.array<chunksize=(50, 50), meta=np.ndarray>
    -     sftgif        (rlat, rlon) float32 2MB dask.array<chunksize=(50, 50), meta=np.ndarray>
    -     sftlf         (rlat, rlon) float32 2MB dask.array<chunksize=(50, 50), meta=np.ndarray>
    -     sftlkf        (rlat, rlon) float32 2MB dask.array<chunksize=(50, 50), meta=np.ndarray>
    -     sftof         (rlat, rlon) float32 2MB dask.array<chunksize=(50, 50), meta=np.ndarray>
          20mWind       (time, rlat, rlon) float32 36GB dask.array<chunksize=(1461, 50, 50), meta=np.ndarray>
    +     20mWinddir    (time, rlat, rlon) float32 36GB dask.array<chunksize=(1461, 50, 50), meta=np.ndarray>
    +     cfia          (time, rlat, rlon) float32 36GB dask.array<chunksize=(1461, 50, 50), meta=np.ndarray>
    +     hur           (time, rlat, rlon) float32 36GB dask.array<chunksize=(1461, 50, 50), meta=np.ndarray>
    +     hurmax        (time, rlat, rlon) float32 36GB dask.array<chunksize=(1461, 50, 50), meta=np.ndarray>
    +     hurmin        (time, rlat, rlon) float32 36GB dask.array<chunksize=(1461, 50, 50), meta=np.ndarray>
          ...            ...
    +     vas           (time, rlat, rlon) float32 36GB dask.array<chunksize=(1461, 50, 50), meta=np.ndarray>
    +     winddir       (time, rlat, rlon) float32 36GB dask.array<chunksize=(1461, 50, 50), meta=np.ndarray>
    +     zcrd09975     (time, rlat, rlon) float32 36GB dask.array<chunksize=(1461, 50, 50), meta=np.ndarray>
          zcrd10000     (time, rlat, rlon) float32 36GB dask.array<chunksize=(1461, 50, 50), meta=np.ndarray>
          snd           (time, rlat, rlon) float32 36GB dask.array<chunksize=(1461, 50, 50), meta=np.ndarray>
          snw           (time, rlat, rlon) float32 36GB dask.array<chunksize=(1461, 50, 50), meta=np.ndarray>
    -     ta            (time, rlat, rlon) float32 36GB dask.array<chunksize=(1461, 50, 50), meta=np.ndarray>
    -     tamax         (time, rlat, rlon) float32 36GB dask.array<chunksize=(1461, 50, 50), meta=np.ndarray>
    -     tamin         (time, rlat, rlon) float32 36GB dask.array<chunksize=(1461, 50, 50), meta=np.ndarray>
    - Attributes: (12/30)
    ?                 ^^
    + Attributes: (12/29)
    ?                 ^^
          Conventions:             CF-1.8
          Remarks:                 Original variable names are following the conven...
          contact:
          doi:                     https://doi.org/10.5194/hess-25-4917-2021
    -     domain:                  NAM
    -     frequency:               fx
    ?                              ^^
    +     frequency:               day
    ?                              ^^^
    +     history:                 DATE_TIME_NS: Variables converted ...
          ...                      ...
          format:                  netcdf
          description:             Original data source: https://hpfx.collab.scienc...
          institute:               Environment and Climate Change Canada
          institute_id:            ECCC
          dataset_description:     https://hpfx.collab.science.gc.ca/~scar700/rcas-...
          dataset_id:              CaSRv3.2

  _______ pavics-sdi-master/docs/source/notebooks/CaSR_basic.ipynb::Cell 1 _______
  Notebook cell execution failed
  Cell 1: Cell outputs differ

  Input:
  from clisops.core import subset
  from dask.diagnostics import ProgressBar
  from matplotlib import pyplot as plt

  # Subset bounding box
  lon_bnds = [-70, -55]
  lat_bnds = [44, 55]

  # Loading the coordinate data speeds up the subsetting process a little
  for coord in ["lat", "lon"]:
      ds[coord] = ds[coord].load()

  # Subset bbox
  bbox = subset.subset_bbox(
      ds, lon_bnds=lon_bnds, lat_bnds=lat_bnds, start_date="1981", end_date="2010"
  )

  # Subset gridpoint
  site = subset.subset_gridpoint(ds, lat=40, lon=-60)

  with xr.set_options(display_expand_data_vars=False, display_expand_coords=False):
      display(bbox)
      display(site)

  Traceback:
   mismatch 'text/plain'

   assert reference_output == test_output failed:

    '<xarray.Data...     CaSRv3.2' == '<xarray.Data...     CaSRv3.2'

    - <xarray.Dataset> Size: 45GB
    ?                         ^
    + <xarray.Dataset> Size: 42GB
    ?                         ^
      Dimensions:       (rlat: 156, rlon: 150, time: 10957)
      Coordinates: (6)
    - Data variables: (49)
    ?                   ^
    + Data variables: (41)
    ?                   ^
    - Attributes: (12/30)
    ?                 ^^
    + Attributes: (12/29)
    ?                 ^^
          Conventions:             CF-1.8
          Remarks:                 Original variable names are following the conven...
          contact:
          doi:                     https://doi.org/10.5194/hess-25-4917-2021
    -     domain:                  NAM
    -     frequency:               fx
    ?                              ^^
    +     frequency:               day
    ?                              ^^^
    +     history:                 DATE_TIME_NS: Variables converted ...
          ...                      ...
          format:                  netcdf
          description:             Original data source: https://hpfx.collab.scienc...
          institute:               Environment and Climate Change Canada
          institute_id:            ECCC
          dataset_description:     https://hpfx.collab.science.gc.ca/~scar700/rcas-...
          dataset_id:              CaSRv3.2

  _______ pavics-sdi-master/docs/source/notebooks/CaSR_basic.ipynb::Cell 4 _______
  Notebook cell execution failed
  Cell 4: Cell outputs differ

  Input:
  bbox.rotated_pole

  Traceback:
   mismatch 'text/plain'

   assert reference_output == test_output failed:

    '<xarray.Data...ude_longitude' == '<xarray.Data...ude_longitude'

    Skipping 116 identical leading characters in diff, use -v to show
    Skipping 92 identical trailing characters in diff, use -v to show
      utes:
    +     grid_north_pole_longitude:  87.59703130293302
          north_pole_grid_longitude:  0.0
          grid_north_pole_latitude:   31.758312454493154
    -     grid_north_pole_longitude:  87.59703130293302
          eart
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants