Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup ios builds, setup basic customizations #205

Merged

Conversation

mykhailodanilenko
Copy link
Contributor

@mykhailodanilenko mykhailodanilenko commented Nov 1, 2024

🚀 Description

This PR changes the application to be configurable from a configuration .env file, as well as introducing a job of building the .app iOS simulator app to the pipeline.
You can go to https://mykhailodanilenko.github.io/web-client/ and observe a custom icon as well as app name on the homepage, other artifacts are also available at https://github.com/mykhailodanilenko/web-client/actions/runs/11628293461.

📄 Motivation and Context

#202 and #18

🧪 How Has This Been Tested?

  • Web (desktop)
  • Web (mobile)
  • Mobile (iOS)
  • Mobile (Android)

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist (copied from README)

  • Squash your changes into a single clear and thoroughly descriptive commit, split changes into multiple commits only when it contributes to readability
  • Reference the GitHub issue that you are contributing on in your commit title or body
  • Sign your commits, as this is required by the automated GitHub PR checks
  • Ensure that the changes adhere to the project code style and formatting rules by running npx eslint . and npx prettier --check ../ from the ./OwnTube.tv/ directory (without errors/warnings)
  • Include links and illustrations in your pull request to make it easy to review
  • Request a review by @mykhailodanilenko, @ar9708 and @mblomdahl

@mykhailodanilenko mykhailodanilenko self-assigned this Nov 1, 2024
@mykhailodanilenko mykhailodanilenko added the enhancement New feature or request label Nov 1, 2024
Copy link
Contributor

@mblomdahl mblomdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool! I downloaded the build from your GHA pipeline and installed it on my iPhone simulator. Works great!

image

.github/workflows/deploy-static-main.yml Outdated Show resolved Hide resolved
@mykhailodanilenko mykhailodanilenko force-pushed the feature/ios-setup branch 23 times, most recently from ddfde4b to 594a47f Compare November 4, 2024 19:27
@mykhailodanilenko mykhailodanilenko force-pushed the feature/ios-setup branch 3 times, most recently from 0a4631f to 04a60ad Compare November 4, 2024 19:39
Copy link
Contributor

@mblomdahl mblomdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! As a follow-up task, can we update the README with what needs to be done to build it?

@mykhailodanilenko mykhailodanilenko merged commit 7fcd0e7 into OwnTube-tv:main Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants