Don't call _endthreadex/pthread_exit #331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning from the thread creation function is documented to be a valid way of exiting a thread on both Windows and pthread systems. Removing the explicit call avoids the need to install libgcc_s.so in initramfs for glibc systems, and slightly reduces code size.
mbroz
pushed a commit
to mbroz/cryptsetup
that referenced
this pull request
Jan 28, 2022
Returning from the thread creation function is documented to be a valid way of exiting a thread on both Windows and pthread systems. Removing the explicit call avoids the need to install libgcc_s.so in initramfs for glibc systems, and slightly reduces code size. Upstream: P-H-C/phc-winner-argon2#331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning from the thread creation function is documented to be a valid
way of exiting a thread on both Windows and pthread systems. Removing
the explicit call avoids the need to install libgcc_s.so in initramfs
for glibc systems, and slightly reduces code size.