Cleanup redundant code (#29) #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@gleckler1 over to you |
6 tasks
Contributor
Author
|
@gleckler1 this has been open for over a month, want to merge? (it will purge a bunch of redundant stuff) |
Collaborator
|
@durack1 The reason it is still there is that I have had some difficulties with your rework. Don't want to remove legacy until convinced of a way forward. Getting access the .py rather than notebook is now urgent for me to make progress. If you change that, I will deal with redundant code once confirming everything is working as advertised. |
Contributor
Author
|
Merging after discussing with @gleckler1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The start of cleanup, will require existing demos to be remapped as per #29.
When merged this will close #29