Skip to content

MJO code technical update #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

MJO code technical update #1296

wants to merge 3 commits into from

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented May 13, 2025

No description provided.

@lee1043 lee1043 marked this pull request as ready for review May 13, 2025 19:49
@lee1043 lee1043 added this to the 3.9.2 milestone Jul 1, 2025
@lee1043 lee1043 self-assigned this Jul 1, 2025
@lee1043 lee1043 requested a review from kristinchang3 July 1, 2025 21:17
@lee1043
Copy link
Contributor Author

lee1043 commented Jul 1, 2025

@kristinchang3 when you have a time could you please review this PR? It would be useful to see if the demo5 runs without any issue with this PR.

@kristinchang3
Copy link
Collaborator

Hi @lee1043 - I am getting a file not found error from the last cell in Demo notebook 5:
image

The Ex2 directory exists, but looks like the image file cannot be created. I am getting this warning in the 2 cells above with the driver script and I'm wondering if that is causing the issue?

Screenshot 2025-07-11 at 8 57 37 AM

@lee1043
Copy link
Contributor Author

lee1043 commented Jul 11, 2025

Hi @kristinchang3, Thank you for help on this PR! Could you see where the demo data is coming from, in particular, demo_data or demo_data_tmp? It looks like we have used them mixed in different demos, so we might want to make notebooks consistent for it.

@kristinchang3
Copy link
Collaborator

@lee1043 it looks like the results from the driver are being saved to demo_data_tmp and there is one obs json file in demo_data .

image

@lee1043
Copy link
Contributor Author

lee1043 commented Jul 15, 2025

@kristinchang3 Thanks for checking it. MJO will take its input from daily data, from obs4MIPs_PCMDI_daily (reference) and CMIP5_demo_timeseries (or CMIP5_demo_data -- need to double check). Let's use demo_data_tmp for now, and worry about unifying demo_data and demo_data_tmp later in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants