PHP 8.4 | File::getMemberProperties() + File::getMethodParameters(): add support for asymmetric visibility #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibility Implements the suggested support per #851 (comment) with one difference: the `set_scope` key will always be available, but will be `false` if no set scope is specified. This is more in line with the other keys in the return array. Includes tests. Includes updated test expectation for the PSR2/PropertyDeclarationSniff. Mind: this sniff still needs further updates! Follow up on 871 Partial fix for 851 Related to 734
…ibility Implements the suggested support per #851 (comment). Includes tests. Follow up on 871 Partial fix for 851 Related to 734
This was referenced Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PHP 8.4 | File::getMemberProperties(): add support for asymmetric visibility
Implements the suggested support per #851 (comment) with one difference: the
set_scopekey will always be available, but will befalseif no set scope is specified. This is more in line with the other keys in the return array.Includes tests.
Includes updated test expectation for the PSR2/PropertyDeclarationSniff. Mind: this sniff still needs further updates!
PHP 8.4 | File::getMethodParameters(): add support for asymmetric visibility
Implements the suggested support per #851 (comment).
Includes tests.
Suggested changelog entry
set_scopearray index in the return value.set_visibilityandset_visibility_tokenarray indexes in the return value.Related issues/external references
Follow up on #871
Fixes for #851
Related to #734
Types of changes