PHP 8.3 | Generic/UpperCaseConstantName: add support for typed constants #332
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have just manually tested this branch with the following code class CompanyRegionsCommand extends Command
{
private const int PAGE_SIZE = 40;
}And I can confirm that the 👍 Good work Juliette @jrfnl |
|
Unless there are objections/someone leaves a comments on this PR, I will merge this tomorrow. |
This sniff is specifically targeted at constant names. PHP 8.3 introduces typed constants. This means that the sniff now needs to jump over a potentially declared constant type to get at the constant name. Fixed now. Includes tests. Fixes squizlabs/PHP_CodeSniffer 3927 Closes squizlabs/PHP_CodeSniffer 3936
jrfnl
force-pushed
the
php-8.3/generic-uppercaseconstantname-support-typed-constants
branch
from
094ab91 to
45bf3ad
Compare
|
Rebased without changes. Merging once the build passes. |
jrfnl
deleted the
php-8.3/generic-uppercaseconstantname-support-typed-constants
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This sniff is specifically targeted at constant names.
PHP 8.3 introduces typed constants. This means that the sniff now needs to jump over a potentially declared constant type to get at the constant name.
Fixed now.
Includes tests.
Suggested changelog entry
Related issues/external references
Related to #106
Fixes squizlabs/PHP_CodeSniffer#3927
Closes squizlabs/PHP_CodeSniffer#3936
Types of changes