Ruleset: hard deprecate support for sniffs not following the naming conventions #892
+263
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
…onventions The new [About Standards for PHP_CodeSniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer/wiki/About-Standards-for-PHP_CodeSniffer) wiki page outlines exactly what the naming conventions are. This PR adds a new Ruleset deprecation notice for when sniffs are encountered which do not follow these conventions. Support for sniffs not following the naming conventions will be removed in PHPCS 4.0. Includes tests. Includes removing two invalid sniffs from the `ExpandSniffDirectoryTest`. These type of sniffs, which don't comply with the PHPCS naming conventions, are now covered via the new tests. Related to 689
jrfnl
force-pushed
the
feature/689-ruleset-hard-deprecate-sniffs-breaking-naming-conventions
branch
from
21fb554 to
d23fa30
Compare
|
Rebased without changes before merging. |
fredden
approved these changes
Apr 14, 2025
jrfnl
deleted the
feature/689-ruleset-hard-deprecate-sniffs-breaking-naming-conventions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new About Standards for PHP_CodeSniffer wiki page outlines exactly what the naming conventions are.
This PR adds a new Ruleset deprecation notice for when sniffs are encountered which do not follow these conventions.
Support for sniffs not following the naming conventions will be removed in PHPCS 4.0.
Includes tests.
Includes removing two invalid sniffs from the
ExpandSniffDirectoryTest. These type of sniffs, which don't comply with the PHPCS naming conventions, are now covered via the new tests.Suggested changelog entry
Added deprecation notices (hard deprecation) for:
Related issues/external references
Related to #689