Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API for AcquisitionFunctionMaximizer #75

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Conversation

Xbc-gressor
Copy link
Collaborator

@Xbc-gressor Xbc-gressor commented Jan 4, 2024

  • Pass the acquisition_function as a parameter when invoking AcquisitionFunctionMaximizer.maximize() instead of during the initialization of AcquisitionFunctionMaximizer. This adjustment allows users to switch the acq_optimizer in Advisor more conveniently.
  • API unified to acq_optimizer.

@jhj0411jhj jhj0411jhj changed the title Dev maximizer Update API for AcquisitionFunctionMaximizer: Jan 4, 2024
@jhj0411jhj jhj0411jhj changed the title Update API for AcquisitionFunctionMaximizer: Update API for AcquisitionFunctionMaximizer Jan 4, 2024
@Xbc-gressor
Copy link
Collaborator Author

Update API for AcquisitionFunctionMaximizer:

  • Pass the acquisition_function as a parameter when invoking AcquisitionFunctionMaximizer.maximize() instead of during the initialization of AcquisitionFunctionMaximizer. This adjustment allows users to switch the acq_optimizer in Advisor more conveniently.
  • API unified to acq_optimizer.

@Xbc-gressor Xbc-gressor merged commit eba9c97 into dev Jan 4, 2024
12 checks passed
@jhj0411jhj jhj0411jhj deleted the dev_maximizer branch January 4, 2024 08:17
Xbc-gressor added a commit that referenced this pull request Feb 2, 2024
* Update API for AcquisitionFunctionMaximizer (#75)

* Rewrite ParEGO (#76)

* rewrite parego
---------

Co-authored-by: Jhj <[email protected]>

* fix bug in plot_pareto_front if there are no enough points for 3d surface

* fix condition in alter_model

* add BaseAdvisor

* remove unused tests

* debug import Iterable for python>=3.10

* add pytest

* remove macos test and py3.7 test

* modify requirements

* show cov in readme.md

* pytest for ac func

---------

Co-authored-by: dusixian <[email protected]>
Co-authored-by: Jhj <[email protected]>
Co-authored-by: jhj <>
Co-authored-by: dusixian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants