TLS/SSL Security Framework #349
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nativu5
reviewed
Nov 6, 2024
.gitignore
Outdated
| @@ -61,13 +61,15 @@ dependencies/.extracted | |||
|
|
|||
| # CMake | |||
| cmake-build-*/ | |||
| build/ | |||
Nativu5
requested changes
Nov 6, 2024
dependencies/cmake/CMakeLists.txt
Outdated
| add_subdirectory(BSThreadPool) | ||
| add_subdirectory(nlohmann_json) | ||
| # add_subdirectory(nlohmann_json) |
| repeated AllowedPartitionQos allowed_partition_qos_list = 5; | ||
| repeated string coordinator_accounts = 6; | ||
| AdminLevel admin_level = 7; | ||
| string password = 3; |
Comment on lines
+17
to
+18
| #include "CtldForCforedServer.h" | ||
| #include "CtldForCranedServer.h" |
There was a problem hiding this comment.
Precompiled header comes first!
| @@ -24,6 +26,7 @@ | |||
|
|
|||
| #include <cxxopts.hpp> | |||
| #include <filesystem> | |||
| #include <memory> | |||
There was a problem hiding this comment.
CtldPreCompiledHeader.h 中应该有了
L-Xiafeng
reviewed
Nov 6, 2024
|
|
||
| DomainSuffix: crane.com | ||
|
|
||
| JwtCertFilePath: /etc/crane/jwt.pem |
There was a problem hiding this comment.
这一堆config新建一个SSL层级吧
SSL:
- CranedCertPath
- Ctld....
- xxxx
| URL_HASH SHA256=b9eb270e3ba8221e4b2bc38723c9a1cb4fa6c241a42908b9a334daff31137406 | ||
| INACTIVITY_TIMEOUT 5 | ||
| ) | ||
| set(JWT_BUILD_EXAMPLES OFF CACHE BOOL "disable building examples" FORCE) |
There was a problem hiding this comment.
这个需要cache吗？
Crane动态链接需不需要修改参数？需要确认一下
huerni
force-pushed
the
dev/tls_security
branch
from
292da88
to
2ae9fd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.