Refactor: Replace libevent with libuvw in Craned #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-Xiafeng
force-pushed
the
refactor/uvw
branch
2 times, most recently
from
dd082ef
to
96f7e03
Compare
L-Xiafeng
changed the title
L-Xiafeng
force-pushed
the
refactor/uvw
branch
from
96f7e03
to
2cd2bd3
Compare
Nativu5
changed the title
RileyWen
reviewed
Nov 12, 2024
RileyWen
reviewed
Nov 12, 2024
| @@ -875,8 +770,8 @@ CraneErr TaskManager::SpawnProcessInInstance_(TaskInstance* instance, | |||
| stderr_fd = | |||
| open(stderr_file_path.c_str(), O_RDWR | O_CREAT | O_TRUNC, 0644); | |||
| if (stderr_fd == -1) { | |||
| CRANE_ERROR("[Child Process] Error: open {}. {}", stderr_file_path, | |||
| strerror(errno)); | |||
| // CRANE_ERROR("[Child Process] Error: open {}. {}", stderr_file_path, | |||
There was a problem hiding this comment.
会死锁，因为spdlog内部也有互斥锁
RileyWen
reviewed
Nov 12, 2024
| int err = istream.GetErrno(); | ||
| CRANE_ERROR("Failed to read socket from parent: {}", strerror(err)); | ||
| } | ||
| // if (!ok) { |
There was a problem hiding this comment.
spdlog内部也有互斥锁，导致子进程死锁，所以里面的log全关了，而且本来也打不出来日志。
RileyWen
reviewed
Nov 12, 2024
|
|
||
| if (!this_->m_is_ending_now_) { | ||
| void TaskManager::SigintCb_() { | ||
| absl::MutexLock lock_guard(&m_mtx_); |
There was a problem hiding this comment.
asan检测出来的，不加锁可能会和LaunchTaskInstanceMt_有datarace
L-Xiafeng
force-pushed
the
refactor/uvw
branch
2 times, most recently
from
f5f02ea
to
c5f0663
Compare
Signed-off-by: Li Junlin <[email protected]>
Signed-off-by: xiafeng <[email protected]>
Signed-off-by: xiafeng <[email protected]>
Signed-off-by: xiafeng <[email protected]>
Signed-off-by: xiafeng <[email protected]>
Signed-off-by: xiafeng <[email protected]>
Signed-off-by: Li Junlin <[email protected]>
Signed-off-by: Li Junlin <[email protected]>
…er fork. Signed-off-by: Li Junlin <[email protected]>
Signed-off-by: Li Junlin <[email protected]>
L-Xiafeng
force-pushed
the
refactor/uvw
branch
from
c5f0663
to
ec93109
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.