Ease integration of MAYO on embedded platforms #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch does some refactoring to allow the direct integration into PQM4. In particular, it does the following changes: - support API using size_t rather than unsigned long long (behind a flag) - save stack space in signing and expand_sk (not having multiple copies of esk on the stack) - fix warnings about shadowing and unused parameters (esp. when using static params) - naming of AES and SHAKE that is compatible with PQM4 - move sample_solution to bitsliced_arithmetic.c so it's easier to replace in optimized implementations
…ned loads/stores Let CI fail on valgrind errors, fix Debug build, fix ct issue in EF
bhess
requested changes
Oct 25, 2023
bhess
approved these changes
Oct 25, 2023
|
Thanks @bhess! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does some refactoring to allow the direct integration into PQM4. In particular, it does the following changes: