Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate image build for docker-compose #206

Open
bbworld1 opened this issue Feb 15, 2021 · 2 comments
Open

Automate image build for docker-compose #206

bbworld1 opened this issue Feb 15, 2021 · 2 comments

Comments

@bbworld1
Copy link
Contributor

The px4flightreview image does not exist until you build it manually, meaning the docker-compose config will not launch until you build the Dockerfile. Combined with a relative lack of documentation, this leads to user confusion.

It would be best to add a build: section in the docker-compose configuration, which will automatically build and tag the image when the configuration is run.

Side note: have we considered pushing an actual official px4flightreview image to Docker Hub? It may be useful to have.

@bkueng
Copy link
Member

bkueng commented Feb 16, 2021

Hi
Feel free to suggest any changes you'd like to see via PR. Personally I don't use docker for this.

@bbworld1
Copy link
Contributor Author

Thanks, I've added it at #207 here.

Docker Hub pushes are trivial to automate now that docker-compose handles building (simply docker-compose build, then docker-compose push), if that's an option you want to explore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants